doc: add and unify even more return values #19955
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsemozhetbyt
added
the
fast-track
nodejs-github-bot
added
doc
BridgeAR
approved these changes
Apr 11, 2018
tools/doc/type-parser.js
Outdated
| @@ -105,6 +107,7 @@ const customTypesMap = { | |||
| 'Timeout': 'timers.html#timers_class_timeout', | |||
| 'Timer': 'timers.html#timers_timers', | |||
|
|
|||
| 'tls.SecureContext': '#tls_tls_createsecurecontext_options', | |||
There was a problem hiding this comment.
Is it intentional that it does not start with tls.html#? The other tls entries have that as a start.
There was a problem hiding this comment.
No, it's a typo. Thank you! I will fix in a fixup commit.
BridgeAR
added
the
author ready
jasnell
approved these changes
Apr 11, 2018
vsemozhetbyt
added a commit
that referenced
this pull request
Apr 12, 2018
PR-URL: #19955 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in df5d41b |
jasnell
pushed a commit
that referenced
this pull request
Apr 16, 2018
PR-URL: #19955 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 1, 2018
PR-URL: nodejs#19955 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes