Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: fix typos of func call in promises.lchmod & lchown #18783

Closed
wants to merge 1 commit into from
Closed

fs: fix typos of func call in promises.lchmod & lchown #18783

wants to merge 1 commit into from

Conversation

shqld
Copy link

@shqld shqld commented Feb 14, 2018

Overview

I fixed 2 typos of function call in fs.promises.

  • in lchmod: fschmod to fchmod
  • in lchown: fschmod to fchown
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

fs

@nodejs-github-bot nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Feb 14, 2018
jasnell
jasnell approved these changes Feb 14, 2018
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh. thank you.

@vsemozhetbyt vsemozhetbyt added promises Issues and PRs related to ECMAScript promises. fast-track PRs that do not need to wait for 48 hours to land. labels Feb 14, 2018
@vsemozhetbyt
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/13177/

@vsemozhetbyt
Copy link
Contributor

Landed in 28dc56d

Thank you!

vsemozhetbyt pushed a commit that referenced this pull request Feb 14, 2018
@vsemozhetbyt
fs: fix typo in promises.lchmod & lchown
28dc56d 
PR-URL: #18783
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@shqld shqld changed the title Fix typos of func call in promises.lchmod & lchown fs: fix typos of func call in promises.lchmod & lchown Feb 15, 2018
@MylesBorins
Copy link
Contributor

Should this be backported to v9.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

@shqld
Copy link
Author

shqld commented Mar 4, 2018

I think this should not be backported but I can't change labels.

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@MayaLekova
fs: fix typo in promises.lchmod & lchown
a297497 
PR-URL: nodejs#18783
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system. promises Issues and PRs related to ECMAScript promises.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@shqld @vsemozhetbyt @MylesBorins @jasnell @lpinca @BridgeAR @nodejs-github-bot