Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: added articles about PR communication in CONTRIBUTING.md #17902

Closed
wants to merge 3 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: added articles about PR communication in CONTRIBUTING.md
Added some references to PR communication articles in
Helpful Ressources inside CONTRIBUTING.md

Fixes: #16359
  • Loading branch information
Salame William committed Dec 28, 2017
commit 1fb9fd7aafad075f3ba715f4ec6baa1ca887f0b8
2 changes: 2 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -828,6 +828,8 @@ The following additional resources may be of assistance:
* [How to create a Minimal, Complete, and Verifiable example](https://stackoverflow.com/help/mcve)
* [core-validate-commit](https://github.com/evanlucas/core-validate-commit) -
A utility that ensures commits follow the commit formatting guidelines.
* How to respectfully and usefully review code part [one](https://mtlynch.io/human-code-reviews-1/) and [two](https://mtlynch.io/human-code-reviews-2/)
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt Dec 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may be wrong, but do we need a comma or a colon between "code" and "part" here?

* [How to write a positive code review](https://css-tricks.com/code-review-etiquette/)

<a id="developers-certificate-of-origin"></a>
## Developer's Certificate of Origin 1.1
Expand Down