Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update AUTHORS list #17452

Closed
wants to merge 1 commit into from
Closed

doc: update AUTHORS list #17452

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Dec 4, 2017

64 new collaborators in two weeks!

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Dec 4, 2017
maclover7
maclover7 approved these changes Dec 4, 2017
View reviewed changes
Copy link
Contributor

@maclover7 maclover7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

mhdawson
mhdawson reviewed Dec 4, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I do see a number of cases were we don't have the full name of the person, but I assume the commit is the same.

Do we need to raise awareness among collaborators to make sure commit comments have the full name ?

@targos
Copy link
Member Author

targos commented Dec 6, 2017

@mhdawson

I do see a number of cases were we don't have the full name of the person, but I assume the commit is the same.

Yes

Do we need to raise awareness among collaborators to make sure commit comments have the full name ?

Maybe it's something that get-metadata could help with. For example print the author's name (as in the commit) next to the GitHub handle. It could even warn if it doesn't match the name in the GitHub profile.
/cc @nodejs/automation

targos added a commit to targos/node that referenced this pull request Dec 6, 2017
@targos
doc: update AUTHORS list
b52c23b 
PR-URL: nodejs#17452
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
@targos
Copy link
Member Author

targos commented Dec 6, 2017

Landed in b52c23b with one more name.

@targos targos closed this Dec 6, 2017
@targos targos deleted the update-authors branch December 6, 2017 08:57
@priyank-p
Copy link
Contributor

Maybe it's something that get-metadata could help with. For example print the author's name (as in the commit) next to the GitHub handle. It could even warn if it doesn't match the name in the GitHub profile.

@targos GitHub API v4 currently does not support getting name, but i added a feature request and it is in API V3 it should be added in about a week or so.

MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@targos @MylesBorins
doc: update AUTHORS list
d13f067 
PR-URL: #17452
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@targos @MylesBorins
doc: update AUTHORS list
53ed055 
PR-URL: #17452
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@targos @gibfahn
doc: update AUTHORS list
92d2c9a 
PR-URL: #17452
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@targos @gibfahn
doc: update AUTHORS list
85ef429 
PR-URL: #17452
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@targos @gibfahn
doc: update AUTHORS list
b49dfee 
PR-URL: #17452
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson left review comments

@BridgeAR BridgeAR BridgeAR approved these changes

@maclover7 maclover7 maclover7 approved these changes

@cjihrig cjihrig cjihrig approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@lpinca lpinca lpinca approved these changes

@evanlucas evanlucas evanlucas approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.