-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "src, tools: add debug symbols for node internals" #17272
Conversation
@@ -178,7 +178,6 @@ | |||
|
|||
'dependencies': [ | |||
'node_js2c#host', | |||
'deps/nghttp2/nghttp2.gyp:nghttp2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmarchini I don't quite understand why this was added. It doesn't seem to be used.
edit: ah, looks like #14901 partially undid 336af9a by accident.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be here, it was accidentally added when the branch was rebased
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No new errors on the CI other than #17270
This reverts commit 446c1ec. Reverted for breaking `make test-v8`. The "find all relevant system headers" logic in `tools/gen-postmortem-metadata.py` needs more work. Also reverts commit e46c3f7. ("tools: fix typo in gen-postmortem-metadata.py".) PR-URL: nodejs#17272 Refs: nodejs#14901 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
63d3976
to
088bba3
Compare
Thanks, landed in 088bba3 in < 48 hours to get the V8 CI back in working shape again. |
This reverts commit 446c1ec. Reverted for breaking `make test-v8`. The "find all relevant system headers" logic in `tools/gen-postmortem-metadata.py` needs more work. Also reverts commit e46c3f7. ("tools: fix typo in gen-postmortem-metadata.py".) PR-URL: #17272 Refs: #14901 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
This reverts commit 446c1ec.
Reverted for breaking
make test-v8
. The "find all relevant systemheaders" logic in
tools/gen-postmortem-metadata.py
needs more work.Also reverts commit e46c3f7.
("tools: fix typo in gen-postmortem-metadata.py".)
CI: https://ci.nodejs.org/job/node-test-pull-request/11662/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1074/