Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove spare message #16830

Closed
wants to merge 1 commit into from
Closed

test: remove spare message #16830

wants to merge 1 commit into from

Conversation

BindiChen
Copy link

Checklist
  • [x ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2017
@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2017
@mscdex mscdex added the child_process Issues and PRs related to the child_process subsystem. label Nov 6, 2017
@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11257/

@Trott
Copy link
Member

Trott commented Nov 7, 2017

This appears to duplicate #16819 which already landed. I'm fairly certain we didn't have duplicate issues but maybe I'm wrong? Did you share with another attendee or something?

@Trott
Copy link
Member

Trott commented Nov 7, 2017

Hello @BindiChen. Welcome and thanks for the PR! Since this duplicates another PR that has already landed, I'm going to close it. Sorry about that! If you'd like a different quick task to work on, feel free to email [email protected] and I (or someone else) will send you one! Thanks for attending Code + Learn!

@Trott Trott closed this Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@BindiChen @joyeecheung @Trott @cjihrig @gireeshpunathil @mscdex @nodejs-github-bot