Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use fixtures in tls-friendly-error-message #15905

Closed
wants to merge 2 commits into from
Closed

test: use fixtures in tls-friendly-error-message #15905

wants to merge 2 commits into from

Conversation

tobyfarley
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@mscdex mscdex added the tls Issues and PRs related to the tls subsystem. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@Trott
Copy link
Member

Trott commented Oct 8, 2017

Hi, @tobyfarley! Welcome and thanks for this. Can you update the test to import fixtures directly (require('../common/fixtures')) ? Then update it to use fixtures.readKey()? The documentation for that is at https://github.com/nodejs/node/tree/master/test/common#fixtures-module.

@refack
Copy link
Contributor

refack commented Oct 9, 2017

@tobyfarley thank you for following up 🥇

Quick CI: https://ci.nodejs.org/job/node-test-commit-linuxone/9171/

@refack refack self-assigned this Oct 9, 2017
@Trott
Copy link
Member

Trott commented Oct 12, 2017

Full CI: https://ci.nodejs.org/job/node-test-pull-request/10656/

jasnell pushed a commit that referenced this pull request Oct 13, 2017
@tobyfarley @jasnell
test: use fixtures in tls-friendly-error-message
42e8254 
PR-URL: #15905
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Oct 13, 2017

Landed in 42e8254

@jasnell jasnell closed this Oct 13, 2017
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 15, 2017
@tobyfarley @addaleax
test: use fixtures in tls-friendly-error-message
da68338 
PR-URL: nodejs/node#15905
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Oct 18, 2017
@tobyfarley @targos
test: use fixtures in tls-friendly-error-message
56cf077 
PR-URL: #15905
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@tobyfarley @MylesBorins
test: use fixtures in tls-friendly-error-message
1fe356d 
PR-URL: #15905
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@tobyfarley @MylesBorins
test: use fixtures in tls-friendly-error-message
3ef7085 
PR-URL: #15905
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@tobyfarley @MylesBorins
test: use fixtures in tls-friendly-error-message
28756b3 
PR-URL: #15905
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@refack refack removed their assignment Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tobyfarley @Trott @refack @jasnell @gibfahn @mscdex @MylesBorins @nodejs-github-bot