Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unused file variable. #15468

Closed
wants to merge 1 commit into from
Closed

src: remove unused file variable. #15468

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Sep 19, 2017

Currently the following compiler warning is displayed:

../src/module_wrap.cc:330:3: warning: unused variable 'file_check'
[-Wunused-variable]
} file_check;
  ^

This commit removes this unused variable.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@danbev
src: remove unused file variable.
9d7e38d 
Currently the following compiler warning is displayed:
../src/module_wrap.cc:330:3: warning: unused variable 'file_check'
[-Wunused-variable]
} file_check;
  ^

This commit removes this unused variable.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 19, 2017
@lpinca
Copy link
Member

lpinca commented Sep 19, 2017

The same fix is also available in #15458.

@danbev
Copy link
Contributor Author

danbev commented Sep 19, 2017

The same fix is also available in #15458.

Thanks, was not aware of that one. I'll close this.

@danbev danbev closed this Sep 19, 2017
@danbev danbev deleted the module_wrap_unused_var branch November 16, 2017 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danbev @lpinca @addaleax @TimothyGu @nodejs-github-bot