doc: fix wrong history entry in deepStrictEqual #15381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
assert
lpinca
approved these changes
Sep 13, 2017
jasnell
approved these changes
Sep 13, 2017
BridgeAR
requested changes
Sep 13, 2017
doc/api/assert.md
Outdated
| @@ -109,13 +109,11 @@ parameter is an instance of an `Error` then it will be thrown instead of the | |||
| <!-- YAML | |||
| added: v1.2.0 | |||
| changes: | |||
| - version: REPLACEME | |||
| - version: v8.5.0 | |||
There was a problem hiding this comment.
This should be kept as REPLACEME because it is a semver-major change.
BridgeAR
approved these changes
Sep 14, 2017
jasnell
pushed a commit
that referenced
this pull request
Sep 15, 2017
PR-URL: #15381 Fixes: #15379 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
|
Landed in a591610 |
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 17, 2017
PR-URL: nodejs/node#15381 Fixes: nodejs/node#15379 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Qard
pushed a commit
to Qard/ayo
that referenced
this pull request
Sep 21, 2017
PR-URL: nodejs/node#15381 Fixes: nodejs/node#15379 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #15379
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
None