-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lint: wrap lines which include RegEx exceeding 80 chars #14607
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
lint: wrap lines which include RegEx exceeding 80 chars
Format commit wrapping lines containing RegEx and exceeding 80 chars. Fixes: #14586
- Loading branch information
commit 59d037fc3cd660342cb80d5e989bad3cc81783eb
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,8 +43,10 @@ assert.strictEqual(url.searchParams, oldParams); // [SameObject] | |
// searchParams is readonly. Under strict mode setting a | ||
// non-writable property should throw. | ||
// Note: this error message is subject to change in V8 updates | ||
assert.throws(() => url.origin = 'http://foo.bar.com:22', | ||
/TypeError: Cannot set property origin of \[object URL\] which has only a getter$/); | ||
assert.throws( | ||
() => url.origin = 'http://foo.bar.com:22', | ||
/^TypeError: Cannot set property origin of \[object URL\] which has only a getter$/ | ||
); | ||
assert.strictEqual(url.origin, 'http://foo.bar.com:21'); | ||
assert.strictEqual(url.toString(), | ||
'http://user:[email protected]:21/aaa/zzz?l=25#test'); | ||
|
@@ -118,8 +120,10 @@ assert.strictEqual(url.hash, '#abcd'); | |
// searchParams is readonly. Under strict mode setting a | ||
// non-writable property should throw. | ||
// Note: this error message is subject to change in V8 updates | ||
assert.throws(() => url.searchParams = '?k=88', | ||
/^TypeError: Cannot set property searchParams of \[object URL\] which has only a getter$/); | ||
assert.throws( | ||
() => url.searchParams = '?k=88', | ||
/^TypeError: Cannot set property searchParams of \[object URL\] which has only a getter$/ | ||
); | ||
assert.strictEqual(url.searchParams, oldParams); | ||
assert.strictEqual(url.toString(), | ||
'https://user2:[email protected]:23/aaa/bbb?k=99#abcd'); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit
\b
->^
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(And below two instances too?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this somehow breaks matching: #14607 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some error messages quote erroneous code before the error message itself, so for these messages, we can't use
^
anchor (or we should add the/m
flag beside).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, then
\b
it is!