Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v6.x backport) doc: change Mac OS X to macOS #12650

Closed
wants to merge 152 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
152 commits
Select commit Hold shift + click to select a range
f05982b
doc: add supported platforms list
mhdawson Mar 17, 2017
76e903e
doc: add supported platforms list for v6.x
mhdawson Mar 20, 2017
6486b97
doc: fix broken URL to event loop guide
sushi90 Mar 3, 2017
078188d
stream: avoid additional validation for Buffers
mscdex Jan 2, 2017
daddf5a
tools, test: require const/let in test
gibfahn Jan 8, 2017
b2fc0f0
test: use eslint to fix var->const/let
gibfahn Mar 9, 2017
7e98f23
doc: fix stylistic issues in api/net.md
aqrln Mar 10, 2017
533e565
test: add arrow functions to test-util-inspect
aqrln Mar 10, 2017
0695c09
test: skip when openssl CLI doesn't exist
sotayamashita Feb 1, 2017
17963a5
build: --without-ssl implies --without-inspector
bnoordhuis Apr 4, 2017
3855504
doc: new TLSSocket has no secure context options
sam-github Dec 30, 2016
a6ab9f2
doc: clarify memory sharing behavior of buffer ctor
zbjornson Jan 13, 2017
b85d15f
test: improve test-fs-access
edsadr Jan 3, 2017
3cde69a
test: refactor test-beforeexit-event-exit.js
cjihrig Jan 2, 2017
a654502
test: s/assert.equal/assert.strictEqual/
gibfahn Jan 8, 2017
acd9bc3
assert, tools: enforce strict (not)equal in eslint
gibfahn Jan 8, 2017
42d1fb1
test: refactor test-stream2-readable-wrap.js
DavidGoussev Dec 31, 2016
f23c818
test: getgroups() may contain duplicate GIDs
sam-github Dec 21, 2016
c555f53
doc,test: tls .ca option supports multi-PEM files
sam-github Dec 21, 2016
54486c0
test: tls cert chain completion scenarios
sam-github Dec 20, 2016
b631966
doc: use correct tls certificate property name
sam-github Dec 20, 2016
cdc354a
test: check tls server verification with addCACert
sam-github Dec 20, 2016
b0daa9b
test: move common tls connect setup into fixtures
sam-github Dec 17, 2016
7b121f1
doc: make os api doc more consistent
evanlucas Jan 25, 2017
dcf20bc
doc: fix typo in STYLE_GUIDE.md
seishun Feb 28, 2017
7a6683e
doc: use common malformed instead of misformatted
jsumners Feb 23, 2017
de13d62
doc: add link to references in net.Socket
joyeecheung Mar 1, 2017
1427c0e
test: skip tests with common.skip
thefourtheye Feb 27, 2017
ea719a1
doc: fixup errors.md
vsemozhetbyt Feb 26, 2017
c60fd7f
net: remove misleading comment
bnoordhuis Feb 27, 2017
f194fb3
test: apply strict mode in test-repl
Trott Feb 27, 2017
64c66d2
doc: fix typo in stream doc
bradley-curran Feb 26, 2017
055d4da
meta: remove out of date ROADMAP.md file
jasnell Feb 25, 2017
c4a14a2
test: improve https coverage to check create connection
Feb 17, 2017
577eb81
test: fix flaky test-https-agent-create-connection
santigimeno Mar 2, 2017
854b3ea
timers: unlock the timers API
Trott Feb 27, 2017
2335d7e
test: enable max-len for test-repl
Trott Feb 26, 2017
51350cb
test: add test-buffer-prototype-inspect
Trott Feb 28, 2017
16f3a99
buffer: refactor Buffer.prototype.inspect()
Trott Feb 28, 2017
1ab3d0f
tools: remove NODE_PATH from environment for tests
Trott Feb 28, 2017
3055ebb
tls: fix macro to check NPN feature
shigeki Mar 2, 2017
c5363b0
test: fix tests when npn feature is disabled.
shigeki Mar 2, 2017
c37a13c
doc: add `Daijiro Wachi` to collaborators
watilde Mar 3, 2017
e6c65b2
url: use `hasIntl` instead of `try-catch`
watilde Feb 28, 2017
e607d2c
test: remove obsolete eslint-disable comment
Trott Mar 2, 2017
c283682
src: remove outdated FIXME in node_crypto.cc
danbev Mar 3, 2017
9ecc2c9
test: changed test1 of test-vm-timeout.js
moe-dizzle Feb 27, 2017
91d694e
doc: fix misleading ASCII comments
rahatarmanahmed Mar 2, 2017
94e50a4
doc: unlock module
Trott Mar 2, 2017
e136893
doc: remove Locked from stability index
Trott Mar 2, 2017
3b1468f
doc: fixed readable.isPaused() version annotation
lfortin Mar 3, 2017
aae362d
test: skip the test with proper TAP message
thefourtheye Feb 27, 2017
a31d6e2
build: fix llvm version detection in freebsd-10
shigeki Mar 3, 2017
2461e25
meta: move WORKING_GROUPS.md to CTC repo
jasnell Feb 25, 2017
5c00610
tools: add links to the stability index reference
michaelcox Mar 2, 2017
d53d375
test: limit lint rule disabling in message test
Trott Mar 6, 2017
d0d9c7c
test: increase coverage of console
DavidCai1111 Mar 2, 2017
60da9ae
test: add script to create 0-dns-cert.pem
shigeki Feb 27, 2017
d24dbe0
test: add test for loading from global folders
richardlau Oct 20, 2016
a2c46ab
module: fix loading from global folders on Windows
richardlau Oct 25, 2016
9136880
doc: add Franziska Hinkelmann to the CTC
rvagg Feb 22, 2017
bc116ab
doc: fix process links to console.log/error
sam-github Mar 6, 2017
d5b4f64
doc: fix occurences of "the the"
JeroenMandersloot Mar 6, 2017
2fa63fc
doc: reduce font size on smaller screens
gibfahn Mar 5, 2017
9c9f232
test: fix flaky test-http-set-timeout-server
santigimeno Mar 10, 2017
874126f
doc: package main can be directory with an index
bmeck Feb 27, 2017
dbb2859
doc: update to current V8 versions
fhinkel Mar 10, 2017
563c2ce
build: add node_use_openssl check to install.py
danbev Mar 9, 2017
9422305
tls: keep track of stream that is closed
jBarz Mar 9, 2017
5284d92
stream_base,tls_wrap: notify on destruct
trevnorris Oct 31, 2016
f3877fa
Partial revert "tls: keep track of stream that is closed"
trevnorris Mar 20, 2017
4180204
test: fix args in parallel/test-fs-null-bytes.js
vsemozhetbyt Mar 3, 2017
e760a1b
events,test: fix TypeError in EventEmitter warning
jseagull Oct 10, 2016
0d4d67a
test: fail when child dies in fork-net
joyeecheung Mar 4, 2017
bde2f16
test: add regex to assert.throws
matejkrajcovic Mar 12, 2017
c8bd99f
test: added test for indexed properties
AnnaMag Mar 9, 2017
d11fd98
test: fix flaky test-domain-abort-on-uncaught
Trott Mar 12, 2017
774e388
test: failing behaviour on sandboxed Proxy
AnnaMag Mar 2, 2017
9ad91d7
test: fix assertion in vm test
AnnaMag Mar 14, 2017
8068d3f
lib: remove unused msg parameter in debug_agent
mr-spd Mar 13, 2017
a103f1f
doc: console.log() -> console.error() in events.md
vsemozhetbyt Mar 12, 2017
ea0dd92
doc: var -> let / const in events.md
vsemozhetbyt Mar 12, 2017
6d61296
doc: correct comment error in stream.md
Alex-Sokolov Mar 11, 2017
12772b0
doc: fix a typo in api/process.md
sabakugaara Mar 10, 2017
39ddd18
doc: add note that vm module is not a security mechanism
krydos Feb 25, 2017
7d507db
doc: add vsemozhetbyt to collaborators
vsemozhetbyt Mar 20, 2017
31dc04e
tls: fix segfault on destroy after partial read
bnoordhuis Mar 17, 2017
d7d0dba
deps: cherry-pick ca0f9573 from V8 upstream
ofrobots Mar 20, 2017
bcb0957
buffer: remove unneeded eslint-disable comment
Trott Mar 17, 2017
88aa556
doc: add missing word in stream.md
jyotman Mar 18, 2017
93d4a44
src: ensure that fd 0-2 are valid on windows
bzoz Mar 14, 2017
d1314ae
doc: fix gitter badge in README
silverwind Mar 20, 2017
57c8dde
benchmark: fix fs\bench-realpathSync.js
vsemozhetbyt Mar 17, 2017
fc94564
test: fix flaky test-tls-socket-close
Trott Mar 19, 2017
e0cc3d2
test: add test for child_process.execFile()
Trott Mar 19, 2017
c9ebc4d
src, buffer: do not segfault on out-of-range index
TimothyGu Mar 19, 2017
b4f6fc0
doc: require uses fs root for '/' prefix
bmeck Mar 17, 2017
de59a13
doc: remove superfluous sample assert code
Trott Mar 20, 2017
e1479f4
doc: correct info in child_process.md
vsemozhetbyt Mar 20, 2017
ea3f061
timers: fix not to close reused timer handle
shigeki Feb 20, 2017
d5f9390
doc: update collaborator email address
Trott Mar 22, 2017
f3f4ac4
test: improve test-vm-cached-data.js
mpelekh Mar 21, 2017
b124d00
test: invalid chars in http client path
lucamaraschi Mar 21, 2017
2c4c4e4
test: refactor test-cli-eval.js
StarryShark Jan 12, 2017
1a05f4a
test: fix broken assertion
cjihrig Jan 16, 2017
627107a
test: refactor test-cli-eval.js
cjihrig Jan 19, 2017
1344ced
test: add coverage for child_process bounds check
Trott Mar 11, 2017
a214fa3
lib: fix event race condition with -e
bnoordhuis Mar 21, 2017
f940679
lib: add comment to script eval _tickCallback
gibfahn Mar 26, 2017
8bcca23
test: refactor test-cluster-disconnect
Trott Mar 22, 2017
b73b761
test: add second argument to assert.throws()
rjbernaldo Mar 24, 2017
cd85dcc
test: add regex for expected error message
jfmercer Mar 23, 2017
ca0cb61
test: test validity of prefix in mkdtempSync
lucamaraschi Mar 23, 2017
d76d0c8
test: replace throw with common.fail
itsmed Nov 19, 2016
32ee556
doc: fix process.stdout fd number
fmy Mar 27, 2017
d74decf
doc: stdout/err/in are all Duplex streams
seppevs Feb 6, 2017
edfa343
test: fix broken tests in test-buffer-includes
aqrln Mar 25, 2017
347ee88
doc: update and modernize examples in fs.ms
vsemozhetbyt Mar 25, 2017
c33e4af
test: fix misleading comment
fhinkel Mar 26, 2017
6786e6e
tools: update dotfile whitelist in .gitignore
targos Mar 29, 2017
6aeaf21
src: fix base64 decoding
seishun Mar 22, 2017
261a2a0
test: reduce buffer size in buffer-creation test
thefourtheye Feb 5, 2017
b5c9c12
doc: add logo to README
silverwind Mar 31, 2017
1f732d3
test: fix flaky test-child-process-exec-timeout
santigimeno Apr 1, 2017
20c38eb
test: increase querystring coverage
DavidCai1111 Apr 2, 2017
9520762
test: performance, remove Popen(shell=True) on Win
refack Mar 30, 2017
eafe88b
test: more robust check for location of `node.exe`
refack Mar 29, 2017
90caad4
doc: add table of contents to README.md
Minimalistic Mar 1, 2017
e9a6ddd
doc: fix string interpolation in Stream 'finish'
vhmth Apr 4, 2017
db28237
doc: modernize and fix code examples in https.md
vsemozhetbyt Apr 2, 2017
fce05e3
build: make configure print statements consistent
danbev Apr 3, 2017
cf411d3
build: add checks for openssl configure options
danbev Apr 3, 2017
6c4f786
test: skip irrelevant test on Windows
Trott Apr 6, 2017
81fceb3
test: add a second argument to assert.throws()
dave-k Mar 30, 2017
72e011e
doc: add aqrln to collaborators
aqrln Apr 7, 2017
c520aef
doc: document the performance team
gibfahn Apr 4, 2017
6577f3e
doc: fix confusing reference in net.md
vsemozhetbyt Apr 5, 2017
663a1ec
doc: update information on test/known_issues
Apr 6, 2017
4bfa2bb
doc: fix confusing example in process.md
vsemozhetbyt Apr 8, 2017
f463c17
tools: ignore URLs in line length linting
Trott Mar 17, 2017
52511b6
doc: add richardlau to collaborators
richardlau Mar 24, 2017
97097af
doc: add refack to collaborators
refack Apr 7, 2017
a40a6a2
deps: backport ec1ffe3 from upstream V8
danbev Mar 27, 2017
8f0f463
doc: clarify out-of-bounds behavior of buf[index]
seishun Feb 10, 2017
117195a
src: add fcntl.h include to node.cc
bzoz Apr 20, 2017
276267f
doc: modernize and fix code examples in modules.md
vsemozhetbyt Apr 5, 2017
6ddea5c
build: use $(RM) in Makefile for consistency
gibfahn Apr 1, 2017
99dab5b
deps: backport 75f2d65f00 from upstream V8
hashseed Apr 20, 2017
9218661
test: refactor several parallel/test-timer tests
BethGriggs Dec 29, 2016
570dd22
doc: change Mac OS X to macOS
Mar 28, 2017
d21dcd1
doc: correct markdown file line lengths
Mar 29, 2017
32de627
doc: update Mac OS X references in releases.md
Mar 29, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: check tls server verification with addCACert
SecureContext.addCACert() adds to the existing root store,
preserving root cert entries. option.ca is applied without
calling SecureContext.addRootCerts() so should add to
the default, empty, root store.

This test confirms that the built-in root CAs are not included
when options.ca is used.

Based on:

shigeki@acd5837

Backport-PR-URL: #12468
PR-URL: #10389
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
  • Loading branch information
sam-github authored and MylesBorins committed Apr 17, 2017
commit cdc354a3e950421b0551309d5f3409f5375786b0
55 changes: 55 additions & 0 deletions test/internet/test-tls-add-ca-cert.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
'use strict';
const common = require('../common');

if (!common.hasCrypto) {
common.skip('missing crypto');
return;
}

// Test interaction of compiled-in CAs with user-provided CAs.

const assert = require('assert');
const fs = require('fs');
const tls = require('tls');

function filenamePEM(n) {
return require('path').join(common.fixturesDir, 'keys', n + '.pem');
}

function loadPEM(n) {
return fs.readFileSync(filenamePEM(n));
}

const caCert = loadPEM('ca1-cert');

const opts = {
host: 'www.nodejs.org',
port: 443,
rejectUnauthorized: true
};

// Success relies on the compiled in well-known root CAs
tls.connect(opts, common.mustCall(end));

// The .ca option replaces the well-known roots, so connection fails.
opts.ca = caCert;
tls.connect(opts, fail).on('error', common.mustCall((err) => {
assert.strictEqual(err.message, 'unable to get local issuer certificate');
}));

function fail() {
assert(false, 'should fail to connect');
}

// New secure contexts have the well-known root CAs.
opts.secureContext = tls.createSecureContext();
tls.connect(opts, common.mustCall(end));

// Explicit calls to addCACert() add to the default well-known roots, instead
// of replacing, so connection still succeeds.
opts.secureContext.context.addCACert(caCert);
tls.connect(opts, common.mustCall(end));

function end() {
this.end();
}