Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: v7.x - #11989 - test: add internal/socket_list tests #12109

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 67 additions & 0 deletions test/parallel/test-internal-socket-list-receive.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
// Flags: --expose-internals
'use strict';

const common = require('../common');
const assert = require('assert');
const EventEmitter = require('events');
const SocketListReceive = require('internal/socket_list').SocketListReceive;

const key = 'test-key';

// Verify that the message won't be sent when slave is not connected.
{
const slave = Object.assign(new EventEmitter(), {
connected: false,
send: common.mustNotCall()
});

const list = new SocketListReceive(slave, key);
list.slave.emit('internalMessage', { key, cmd: 'NODE_SOCKET_NOTIFY_CLOSE' });
}

// Verify that a "NODE_SOCKET_ALL_CLOSED" message will be sent.
{
const slave = Object.assign(new EventEmitter(), {
connected: true,
send: common.mustCall((msg) => {
assert.strictEqual(msg.cmd, 'NODE_SOCKET_ALL_CLOSED');
assert.strictEqual(msg.key, key);
})
});

const list = new SocketListReceive(slave, key);
list.slave.emit('internalMessage', { key, cmd: 'NODE_SOCKET_NOTIFY_CLOSE' });
}

// Verify that a "NODE_SOCKET_COUNT" message will be sent.
{
const slave = Object.assign(new EventEmitter(), {
connected: true,
send: common.mustCall((msg) => {
assert.strictEqual(msg.cmd, 'NODE_SOCKET_COUNT');
assert.strictEqual(msg.key, key);
assert.strictEqual(msg.count, 0);
})
});

const list = new SocketListReceive(slave, key);
list.slave.emit('internalMessage', { key, cmd: 'NODE_SOCKET_GET_COUNT' });
}

// Verify that the connections count is added and an "empty" event
// will be emitted when all sockets in obj were closed.
{
const slave = new EventEmitter();
const obj = { socket: new EventEmitter() };

const list = new SocketListReceive(slave, key);
assert.strictEqual(list.connections, 0);

list.add(obj);
assert.strictEqual(list.connections, 1);

list.on('empty', common.mustCall((self) => assert.strictEqual(self, list)));

obj.socket.emit('close');
assert.strictEqual(list.connections, 0);
}
114 changes: 114 additions & 0 deletions test/parallel/test-internal-socket-list-send.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,114 @@
// Flags: --expose-internals
'use strict';

const common = require('../common');
const assert = require('assert');
const EventEmitter = require('events');
const SocketListSend = require('internal/socket_list').SocketListSend;

const key = 'test-key';

// Verify that an error will be received in callback when slave is not
// connected.
{
const slave = Object.assign(new EventEmitter(), { connected: false });
assert.strictEqual(slave.listenerCount('internalMessage'), 0);

const list = new SocketListSend(slave, 'test');

list._request('msg', 'cmd', common.mustCall((err) => {
assert.strictEqual(err.message, 'Slave closed before reply');
assert.strictEqual(slave.listenerCount('internalMessage'), 0);
}));
}

// Verify that the given message will be received in callback.
{
const slave = Object.assign(new EventEmitter(), {
connected: true,
send: function(msg) {
process.nextTick(() =>
this.emit('internalMessage', { key, cmd: 'cmd' })
);
}
});

const list = new SocketListSend(slave, key);

list._request('msg', 'cmd', common.mustCall((err, msg) => {
assert.strictEqual(err, null);
assert.strictEqual(msg.cmd, 'cmd');
assert.strictEqual(msg.key, key);
assert.strictEqual(slave.listenerCount('internalMessage'), 0);
assert.strictEqual(slave.listenerCount('disconnect'), 0);
}));
}

// Verify that an error will be received in callback when slave was
// disconnected.
{
const slave = Object.assign(new EventEmitter(), {
connected: true,
send: function(msg) { process.nextTick(() => this.emit('disconnect')); }
});

const list = new SocketListSend(slave, key);

list._request('msg', 'cmd', common.mustCall((err) => {
assert.strictEqual(err.message, 'Slave closed before reply');
assert.strictEqual(slave.listenerCount('internalMessage'), 0);
}));
}

// Verify that a "NODE_SOCKET_ALL_CLOSED" message will be received
// in callback.
{
const slave = Object.assign(new EventEmitter(), {
connected: true,
send: function(msg) {
assert.strictEqual(msg.cmd, 'NODE_SOCKET_NOTIFY_CLOSE');
assert.strictEqual(msg.key, key);
process.nextTick(() =>
this.emit('internalMessage', { key, cmd: 'NODE_SOCKET_ALL_CLOSED' })
);
}
});

const list = new SocketListSend(slave, key);

list.close(common.mustCall((err, msg) => {
assert.strictEqual(err, null);
assert.strictEqual(msg.cmd, 'NODE_SOCKET_ALL_CLOSED');
assert.strictEqual(msg.key, key);
assert.strictEqual(slave.listenerCount('internalMessage'), 0);
assert.strictEqual(slave.listenerCount('disconnect'), 0);
}));
}

// Verify that the count of connections will be received in callback.
{
const count = 1;
const slave = Object.assign(new EventEmitter(), {
connected: true,
send: function(msg) {
assert.strictEqual(msg.cmd, 'NODE_SOCKET_GET_COUNT');
assert.strictEqual(msg.key, key);
process.nextTick(() =>
this.emit('internalMessage', {
key,
count,
cmd: 'NODE_SOCKET_COUNT'
})
);
}
});

const list = new SocketListSend(slave, key);

list.getConnections(common.mustCall((err, msg) => {
assert.strictEqual(err, null);
assert.strictEqual(msg, count);
assert.strictEqual(slave.listenerCount('internalMessage'), 0);
assert.strictEqual(slave.listenerCount('disconnect'), 0);
}));
}