-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add statement about support for dependencies #11942
Conversation
- In the review of nodejs#11872 we pulled out the discussion of supporting dependencies. This PR adds back that statement. - Update README.md to indicatte BUILDING.md contains the list of supported platforms.
To start the conversation where it was left of in the last PR @bnoordhuis suggested we not include a statement about dependency support:
|
### Shared libraries & dependencies | ||
|
||
Node.js intends to support building against shared representations of | ||
dependencies found in the [*deps*](./deps/) directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no deps
directory in the doc/api
directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, prefer [..][..]
format to mention links.
@thefourtheye, BUILDING.md is not in in the In terms of [..][..], it was originally in that format but it was suggested in the review of the last PR that it be changed to .. as it seems people were not aware the [..][..] format was going to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with @thefourtheye's nit addressed.
I'm ambivalent. This has potentially far-ranging implications and "intends to support" is stretching it when we don't do any actual testing. "If it works, great; if not, send pull requests" would be more honest. |
@rvagg can you chime in here ? Since we don't test building with shared libraries I'd favor just leaving it out. |
ping @rvagg. Would like your input to decide if we should add a statement with respect to dependencies or just close this PR. |
pulled out the discussion of supporting dependencies. This
PR adds back that statement.
of supported platforms. ( I missed this part in the original PR)
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
doc