Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky parallel/test-force-repl on Windows #8483

Closed
Trott opened this issue Sep 10, 2016 · 0 comments
Closed

Investigate flaky parallel/test-force-repl on Windows #8483

Trott opened this issue Sep 10, 2016 · 0 comments
Labels
repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.

Comments

@Trott
Copy link
Member

Trott commented Sep 10, 2016

version 7.0.0-pre (current master)

https://ci.nodejs.org/job/node-test-binary-windows/3724/RUN_SUBSET=3,VS_VERSION=vcbt2015,label=win10/console:

not ok 78 parallel/test-force-repl
# c:\workspace\node-test-binary-windows\RUN_SUBSET\3\VS_VERSION\vcbt2015\label\win10\test\parallel\test-force-repl.js:10
#   throw new Error('timeout!');
#   ^
# 
# Error: timeout!
#     at Timeout._onTimeout (c:\workspace\node-test-binary-windows\RUN_SUBSET\3\VS_VERSION\vcbt2015\label\win10\test\parallel\test-force-repl.js:10:9)
#     at tryOnTimeout (timers.js:232:11)
#     at Timer.listOnTimeout (timers.js:202:5)
  ---
  duration_ms: 3.123
  ...

Looks like the 1 second timeout is probably too short. Doesn't seem to be any reason not to move it up to 5 seconds or something, so that's what I'll do.

In the meantime, stress test: https://ci.nodejs.org/job/node-stress-single-test/906/nodes=win10/console
@Trott Trott added repl Issues and PRs related to the REPL subsystem. windows Issues and PRs related to the Windows platform. test Issues and PRs related to the tests. labels Sep 10, 2016
Trott added a commit to Trott/io.js that referenced this issue Sep 10, 2016
@Trott
test: fix flaky test-force-repl
4dfb44b 
Increase time allowed for startup from 1 second to 5 seconds to avoid
occasional flakiness. While at it, refactor a few minor things such as
var->const and using common.mustCall().

Fixes: nodejs#8483
@Trott Trott mentioned this issue Sep 10, 2016
Closed
2 tasks
@Trott Trott closed this as completed in ad1a9dd Sep 14, 2016
MylesBorins pushed a commit that referenced this issue Sep 30, 2016
@Trott
test: fix flaky test-force-repl
719453e 
Increase time allowed for startup from 1 second to 5 seconds to avoid
occasional flakiness. While at it, refactor a few minor things such as
var->const and using common.mustCall().

Fixes: #8483
PR-URL: #8484
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this issue Oct 10, 2016
@Trott
test: fix flaky test-force-repl
7d6ce04 
Increase time allowed for startup from 1 second to 5 seconds to avoid
occasional flakiness. While at it, refactor a few minor things such as
var->const and using common.mustCall().

Fixes: #8483
PR-URL: #8484
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Fishrock123 pushed a commit that referenced this issue Oct 11, 2016
@Trott @Fishrock123
test: fix flaky test-force-repl
ff238c8 
Increase time allowed for startup from 1 second to 5 seconds to avoid
occasional flakiness. While at it, refactor a few minor things such as
var->const and using common.mustCall().

Fixes: #8483
PR-URL: #8484
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit that referenced this issue Oct 18, 2016
@Trott @rvagg
test: fix flaky test-force-repl
c77f966 
Increase time allowed for startup from 1 second to 5 seconds to avoid
occasional flakiness. While at it, refactor a few minor things such as
var->const and using common.mustCall().

Fixes: #8483
PR-URL: #8484
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this issue Oct 26, 2016
@Trott @MylesBorins
test: fix flaky test-force-repl
69404ec 
Increase time allowed for startup from 1 second to 5 seconds to avoid
occasional flakiness. While at it, refactor a few minor things such as
var->const and using common.mustCall().

Fixes: #8483
PR-URL: #8484
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix flaky test-force-repl Trott/io.js
1 participant
@Trott