Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninit field at src/crypto/crypto_rsa.h RSACipherConfig #56693

Closed
wooffie opened this issue Jan 22, 2025 · 1 comment
Closed

Uninit field at src/crypto/crypto_rsa.h RSACipherConfig #56693

wooffie opened this issue Jan 22, 2025 · 1 comment

Comments

@wooffie
Copy link
Contributor

wooffie commented Jan 22, 2025

Version

20.18.0

Platform

any

Subsystem

crypto

What steps will reproduce the bug?

Default ctor of RSACipherConfig class cannot initialize field CryptoJobMode mode

RSACipherConfig() = default;

Consider set default value for mode, otherwise it is undefined behavior

P.S. I learn some code uses that, looks its not critical, but will be fine to eliminate this bug

How often does it reproduce? Is there a required condition?

By using default ctor and access field mode

What is the expected behavior? Why is that the expected behavior?

Field should have default value

What do you see instead?

No default value

Additional information

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Reporter: Burkov Egor ([email protected]).

Organization: R-Vision ([email protected]).

wooffie added a commit to wooffie/node that referenced this issue Jan 22, 2025
wooffie added a commit to wooffie/node that referenced this issue Jan 24, 2025
jasnell pushed a commit that referenced this issue Jan 25, 2025
Using default init of enum is UB

Refs: #56693
PR-URL: #56701
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this issue Jan 27, 2025
Using default init of enum is UB

Refs: #56693
PR-URL: #56701
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this issue Jan 30, 2025
Using default init of enum is UB

Refs: #56693
PR-URL: #56701
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@wooffie
Copy link
Contributor Author

wooffie commented Jan 30, 2025

Solved #56701

@wooffie wooffie closed this as completed Jan 30, 2025
hvanness pushed a commit to hvanness/node that referenced this issue Jan 30, 2025
Using default init of enum is UB

Refs: nodejs#56693
PR-URL: nodejs#56701
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this issue Jan 31, 2025
Using default init of enum is UB

Refs: #56693
PR-URL: #56701
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this issue Feb 4, 2025
Using default init of enum is UB

Refs: #56693
PR-URL: #56701
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this issue Feb 6, 2025
Using default init of enum is UB

Refs: #56693
PR-URL: #56701
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant