Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node:sqlite support statement.run with TypedArray #56384

Closed
himself65 opened this issue Dec 28, 2024 · 1 comment · Fixed by #56385
Closed

node:sqlite support statement.run with TypedArray #56384

himself65 opened this issue Dec 28, 2024 · 1 comment · Fixed by #56385
Labels
feature request Issues that request new features to be added to Node.js.

Comments

@himself65
Copy link
Member

What is the problem this feature will solve?

for (const [id, vector] of items) {
  insertStmt.run(BigInt(id), new Float32Array(vector));
}

What is the feature you are proposing to solve the problem?

sqlite3 supports this!

What alternatives have you considered?

I have to add a wrapper to uint8array for now
@himself65 himself65 added the feature request Issues that request new features to be added to Node.js. label Dec 28, 2024
@github-project-automation github-project-automation bot moved this to Awaiting Triage in Node.js feature requests Dec 28, 2024
@himself65 himself65 mentioned this issue Dec 28, 2024
Merged
@Rhopz12

This comment has been minimized.

Sign in to view
targos pushed a commit that referenced this issue Jan 13, 2025
@himself65 @aduh95 @targos
sqlite: support TypedArray and DataView in StatementSync
457abb7 
Co-authored-by: Antoine du Hamel <[email protected]>
PR-URL: #56385
Fixes: #56384
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this issue Jan 13, 2025
@himself65 @aduh95 @Ceres6
sqlite: support TypedArray and DataView in StatementSync
e61c376 
Co-authored-by: Antoine du Hamel <[email protected]>
PR-URL: nodejs#56385
Fixes: nodejs#56384
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
aduh95 added a commit that referenced this issue Jan 31, 2025
@himself65 @aduh95
sqlite: support TypedArray and DataView in StatementSync
ff4ec51 
Co-authored-by: Antoine du Hamel <[email protected]>
PR-URL: #56385
Fixes: #56384
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
aduh95 added a commit that referenced this issue Feb 4, 2025
@himself65 @aduh95
sqlite: support TypedArray and DataView in StatementSync
07ff3dd 
Co-authored-by: Antoine du Hamel <[email protected]>
PR-URL: #56385
Fixes: #56384
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Issues that request new features to be added to Node.js.
Projects
Node.js feature requests
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sqlite: support TypedArray and DataView in StatementSync himself65/node
2 participants
@himself65 @Rhopz12