-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assert.partialDeepStrictEqual not working when comparing [0] and [-0] #56230
Labels
Comments
puskin94
added a commit
to puskin94/node
that referenced
this issue
Dec 12, 2024
puskin94
added a commit
to puskin94/node
that referenced
this issue
Dec 12, 2024
puskin94
added a commit
to puskin94/node
that referenced
this issue
Dec 12, 2024
puskin94
added a commit
to puskin94/node
that referenced
this issue
Dec 12, 2024
puskin94
added a commit
to puskin94/node
that referenced
this issue
Dec 12, 2024
puskin94
added a commit
to puskin94/node
that referenced
this issue
Dec 12, 2024
puskin94
added a commit
to puskin94/node
that referenced
this issue
Dec 15, 2024
puskin94
added a commit
to puskin94/node
that referenced
this issue
Dec 15, 2024
puskin94
added a commit
to puskin94/node
that referenced
this issue
Dec 21, 2024
aduh95
pushed a commit
that referenced
this issue
Jan 2, 2025
Fixes: #56230 PR-URL: #56237 Reviewed-By: James M Snell <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Xuguang Mei <[email protected]> Reviewed-By: Jordan Harband <[email protected]>
aduh95
pushed a commit
that referenced
this issue
Jan 31, 2025
Fixes: #56230 PR-URL: #56237 Reviewed-By: James M Snell <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Xuguang Mei <[email protected]> Reviewed-By: Jordan Harband <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Version
v22.12.0
Platform
Subsystem
No response
What steps will reproduce the bug?
const assert = require('assert');
assert.throws(() => assert.deepStrictEqual([0], [-0]), Error);
assert.throws(() => assert.partialDeepStrictEqual([0], [-0]), Error); // This will fail
How often does it reproduce? Is there a required condition?
Always
What is the expected behavior? Why is that the expected behavior?
assert.partialDeepStrictEqual
should behave asassert.deepStrictEqual
What do you see instead?
The method call does not throw
Additional information
The text was updated successfully, but these errors were encountered: