-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dgram socket.send()
documentation needs clarification
#5124
Comments
cc: @mcollina |
That is a very good idea, if this is working correctly. |
Thanks @silverwind! And thanks for reviewing @Trott! @eljefedelrodeodeljefe what do you refer to? #4374 should work as expected yes. Just to clarify:
yes, agreed. I will send a PR to update the docs and resolve this. |
@mcollina nothing special. Just haven't tested passing non-Buffer primitives. |
@eljefedelrodeodeljefe please do :). |
PR sent #5130 |
Fixes: nodejs#5124 See: nodejs#4374 PR-URL: nodejs#5130 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fixes: #5124 See: #4374 PR-URL: #5130 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fixes: #5124 See: #4374 PR-URL: #5130 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fixes: nodejs#5124 See: nodejs#4374 PR-URL: nodejs#5130 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
In the version of the
dgram
doc that is current as of this writing, the first argument (buf
) is described initially as:However, it is subsequently described as a Buffer object only:
Additionally, it is not clear what
offset
andlength
mean when thebuf
argument is an array. It's also not clear if the multi-byte caveat applies ifbuf
is a string or only ifbuf
is a Buffer object.It may be worth changing the name from
buf
tomsg
or something like that./cc @nodejs/documentation
The text was updated successfully, but these errors were encountered: