Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a nodejs/startup team #35215

Closed
joyeecheung opened this issue Sep 15, 2020 · 13 comments
Closed

Create a nodejs/startup team #35215

joyeecheung opened this issue Sep 15, 2020 · 13 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@joyeecheung
Copy link
Member

Hi, I propose to create a nodejs/startup (or maybe nodejs/bootstrap?) team which can be the owner of these files

  • benchmark/misc/startup.js
  • src/node.cc
  • src/node_code_cache_stub.cc
  • src/node_native_module*
  • lib/internal/bootstrap/*
  • tools/code_cache/*
  • tools/snapshot/*

I have been working on including more of the startup process into the snapshot and supporting userland snapshots (initial goal is to be able to snapshot a warmed-up HTTP server and then dehydrate it from a snapshot during startup), it would be helpful to create a team for collaborators who are interested in the startup process and optimization to join and collaborate.

cc @nodejs/tsc

@joyeecheung joyeecheung added the meta Issues and PRs related to the general management of the project. label Sep 15, 2020
@MylesBorins
Copy link
Contributor

I have a slight preference to bootstrap but not massive. Startup makes me think of a company 😂

@mmarchini
Copy link
Contributor

+1 for creating the team

I have a slight preference to nodejs/startup, bootstrap reminds me of https://getbootstrap.com/2.0.2/, or makes me think of scaffolding tools 😅. I guess naming is hard

@MylesBorins
Copy link
Contributor

nodejs/startup-bootstrap it is 😉

@devsnek
Copy link
Member

devsnek commented Sep 15, 2020

nodejs/people-interested-in-node-js-startup-and-environment-bootstrapping

@gireeshpunathil
Copy link
Member

+1 to any name. will this team also focus on the embedding topics, or will stick to snapshoting?

@joyeecheung
Copy link
Member Author

@gireeshpunathil I think it would be better to have a team dedicated to embedding since it's more than just about startup (e.g. maybe also how the instance shuts down or how a virtual file system can be supported)

@XadillaX
Copy link
Contributor

I want to join this team because I'm doing something to modify start up for our own customized Node.js.

@joyeecheung
Copy link
Member Author

I was about to create the team and then remembered that we still have not settled down on the name. Please 👍 this reply if you prefer nodejs/startup and 🎉 if you prefer nodejs/bootstrap (I assume we are not going to take longer names but feel free to reply if you want to make it a vote option 😂)

@mhdawson
Copy link
Member

@danbev FYI in case you missed this. I think you were doing some investigation in this area.

@drewswanner
Copy link

I would be interested in helping out. I have been looking over the startup process myself.

@danbev
Copy link
Contributor

danbev commented Sep 23, 2020

@danbev FYI in case you missed this. I think you were doing some investigation in this area.

Thanks, I had missed it.

I'd be interested in joining this team. Thanks

@XadillaX
Copy link
Contributor

How about pre-userland?

@joyeecheung
Copy link
Member Author

I created a team with me @danbev and @XadillaX and opened #35406.

@drewswanner Since this team will be CODEOWNERS it is reserved for collaborators. Please check out https://github.com/nodejs/node/blob/master/GOVERNANCE.md#collaborators on how to become a collaborator, thanks!

danielleadams pushed a commit that referenced this issue Oct 6, 2020
PR-URL: #35406
Fixes: #35215
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this issue Jan 8, 2021
PR-URL: nodejs#35406
Fixes: nodejs#35215
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants