Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refresh tmpDir before using common PIPE #3227

Closed
kapouer opened this issue Oct 6, 2015 · 1 comment
Closed

test: refresh tmpDir before using common PIPE #3227

kapouer opened this issue Oct 6, 2015 · 1 comment
Assignees
@Trott
Labels
test Issues and PRs related to the tests.

Comments

@kapouer
Copy link
Contributor

kapouer commented Oct 6, 2015

I typically have a missing test/tmp.0/ when running the test suite, failing
test/parallel/test-async-wrap-check-providers.js
since this is the first one to use it.
Calling common.refreshTmpDir(); before first use of common.PIPE is enough;
but i suppose it'd be better to call it everywhere it is used.
@Trott Trott added the test Issues and PRs related to the tests. label Oct 6, 2015
@Trott Trott self-assigned this Oct 7, 2015
@Trott Trott mentioned this issue Oct 7, 2015
Closed
Trott added a commit to Trott/io.js that referenced this issue Oct 7, 2015
@Trott
test: refresh temp directory when using pipe
25f02bf 
common.PIPE resides in the temp directory (except on Windows). Insure
that the temp directory is refreshed in tests that use common.PIPE.

Fixes: nodejs#3227
@Trott Trott closed this as completed in a1040f2 Oct 9, 2015
@Trott
Copy link
Member

Trott commented Oct 9, 2015

Fixed in a1040f2.

Trott added a commit that referenced this issue Oct 10, 2015
@Trott @jasnell
test: refresh temp directory when using pipe
7a5ae34 
common.PIPE resides in the temp directory (except on Windows). Insure
that the temp directory is refreshed in tests that use common.PIPE.

PR-URL: #3231
Fixes: #3227
Reviewed-By: Johan Bergström <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Trott Trott

Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: pipe requires tmpdir Trott/io.js
2 participants
@kapouer @Trott