Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buffer api error since 13.3.0 #31134

Closed
gengjiawen opened this issue Dec 30, 2019 · 2 comments
Closed

Buffer api error since 13.3.0 #31134

gengjiawen opened this issue Dec 30, 2019 · 2 comments
Assignees
@addaleax
Labels
node-api Issues and PRs related to the Node-API.

Comments

@gengjiawen
Copy link
Member

Full detail:
node-ffi-napi/node-ffi-napi#48 (comment)

on 13.30 and after:

'node example/abs.js' terminated by signal SIGSEGV (Address boundary error)

on master

terminated by signal SIGILL (Illegal instruction)

cc @nodejs/v8 @nodejs/n-api
@addaleax addaleax added the node-api Issues and PRs related to the Node-API. label Dec 30, 2019
@addaleax
Copy link
Member

@gengjiawen The errors on master and v13.x are very different.

On v13.x, #30666 is probably the PR that exposed this bug.

The master issue is related to the V8 ArrayBuffer BackingStore API changes, which are a breaking change for addons.

@addaleax addaleax self-assigned this Dec 30, 2019
addaleax added a commit to addaleax/node that referenced this issue Dec 30, 2019
@addaleax
n-api: keep napi_env alive while it has finalizers
c109b3c 
Manage the napi_env refcount from Finalizer instances, as the
finalizer may refer to the napi_env until it is deleted.

Fixes: nodejs#31134
Fixes: node-ffi-napi/node-ffi-napi#48
@addaleax addaleax mentioned this issue Dec 30, 2019
Closed
3 tasks
@gengjiawen
Copy link
Member Author

The master issue is related to the V8 ArrayBuffer BackingStore API changes, which are a breaking change for addons.

Is there any docs for developer to migrate this api in docs ?

targos pushed a commit that referenced this issue Jan 6, 2020
@addaleax @targos
n-api: keep napi_env alive while it has finalizers
d771221 
Manage the napi_env refcount from Finalizer instances, as the
finalizer may refer to the napi_env until it is deleted.

Fixes: #31134
Fixes: node-ffi-napi/node-ffi-napi#48
PR-URL: #31140
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this issue Jan 14, 2020
@addaleax @targos
n-api: keep napi_env alive while it has finalizers
b69f2dd 
Manage the napi_env refcount from Finalizer instances, as the
finalizer may refer to the napi_env until it is deleted.

Fixes: #31134
Fixes: node-ffi-napi/node-ffi-napi#48
PR-URL: #31140
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
BethGriggs pushed a commit that referenced this issue Feb 6, 2020
@addaleax @BethGriggs
n-api: keep napi_env alive while it has finalizers
af5c489 
Manage the napi_env refcount from Finalizer instances, as the
finalizer may refer to the napi_env until it is deleted.

Fixes: #31134
Fixes: node-ffi-napi/node-ffi-napi#48
PR-URL: #31140
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@addaleax addaleax

Labels
node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

n-api: keep napi_env alive while it has finalizers addaleax/node
2 participants
@addaleax @gengjiawen