Node Foundation TSC Meeting 2015-09-02 #2654
Comments
|
Would love it if we could include a quick discussion on nominating new TSC members. |
|
(At least just to pull together a short list, not necessarily to decide on today) |
|
A summary for the TS of Inspecting Node.js with Chrome DevTools #2546 would be appreciated from anyone involved in there, particularly what is it that the TSC needs to care about and are we being called upon to make decisions here. Preferably this should be given here before the meeting so we don't end up wasting all our time trying to grok it all. I tagged deps: update v8 to 4.5.103.30 #2632 because there is an outstanding question of whether we want to try and slip V8 4.5 into v4 since it (surprisingly) went stable today/yesterday. There's pros and cons to this. Pros: we get a supported V8 for longer, we get some bugs fixed and some new features like arrow functions (a weak justification but I like how this adds to the "upgrade to v4" story that we need to be pushing), possibly some perf improvements (including a potential backport or @indutny's patch that just landed there). Cons: Uncertain at this stage if NAN supports this version, it was supposed to but it looks like the V8 team may have slipped a breaking API change in that wasn't pre-announced, there's also some potential pain for addon authors who may think they are ready when in fact they are not since there has been a full |
|
TSC expansion discussion absolutely, I started an email thread about that but we should use some of the private time at the begining of the meeting to talk openly about it, I'd love to see us bring in more of the quality collaborators we have and get some more diverse perspectives and skills! |
It would be good if this could be made a bit more concrete. Based on the thread it looks like this is referring to
Just want to point out that this should have been giving deprecation warnings, so there's at least some chance they'd be aware. Although there's no guarantee addon authors have been compiling with new enough V8, so I understand the general point. |
|
@domenic sorry, it's not - static Local<Function> New(Isolate* isolate,
- FunctionCallback callback,
- Local<Value> data = Local<Value>(),
- int length = 0);
+ static MaybeLocal<Function> New(Local<Context> context,
+ FunctionCallback callback,
+ Local<Value> data = Local<Value>(),
+ int length = 0);
+ static V8_DEPRECATE_SOON(
+ "Use maybe version",
+ Local<Function> New(Isolate* isolate, FunctionCallback callback,
+ Local<Value> data = Local<Value>(), int length = 0));Unfortunately I haven't been able to do any testing on this, no time at all. If anyone else has time it'd be great to get some testing of NAN on this version. @kkoopa do you have time to verify the NAN test suite against #2632 on top of |
Handle is defined like this in the header file: #if !defined(V8_IMMINENT_DEPRECATION_WARNINGS)
// Local is an alias for Local for historical reasons.
template <class T>
using Handle = Local<T>;
#endifIf I understand it well, as long as we don't enable |
|
@targos my point is about all of the core APIs now exporting |
|
@rvagg here is a list of all npm packages where the nan dependency satisfies 2.0.8: |
|
All Function::New() does is call FunctionTemplate::New()->GetFunction(). It is probably not even in common use, as it was not available before 0.12. There are four ways of fixing it:
Witchever the resolution is, I strongly oppose bumping the major version of NAN for this uselessness. 2.x is here to stay for at year, breakage be damned. The Handle stuff is a non-issue. It is trivial to fix, it has been known for over two years that it needs to be fixed, and there is no promise of forward compatibility. It was well known already before the release of io.js 3.0. On September 2, 2015 4:07:59 PM GMT+03:00, Rod Vagg [email protected] wrote:
|
|
Sorry, I can't make it today. |
|
Most likely I won't be able to attend today. |
Fishrock123
added
the
meta
|
@kkoopa so my understanding of your four ways to fix it is that you would find patching NAN to keep the existing behavior or update to the new behavior both acceptable? Neither would require a major version bump, correct? Anyway, again it sounds like this is not actually a removal, or even a deprecation, just a deprecation-soon. So NAN doesn't need to do anything at all, if it doesn't want to, at least for two more V8 releases. As @rvagg says though, getting some testing in would be crucial to confirm. |
|
@domenic Patching to update to new behavior would be a breaking change, but I still do not consider it significant enough to warrant a major version bump, regardless of semver this or semver that. The construct is probably not used outside of NAN's test suite. |
|
OK. So it sounds like patching NAN to keep the existing behavior is the way to go. |
|
It's probably the easiest fix, yes. Will take a minute to cook up. Personally I would prefer removing the commit from V8, since it was not in 4.3, where it belonged, and I am tired of the haphazard flailing back and forth with breaking changes everywhere from one patch release to another with no concrete plan. But this is mostly just me being obstinate. On September 2, 2015 5:58:56 PM GMT+03:00, Domenic Denicola [email protected] wrote:
|
|
OT/meta: Could the Soundcloud account where the recording of the meeting is uploaded be made part of the meeting notes and/or the announcement issue? I missed the switch and was still looking at the Youtube account wondering why the recordings weren't showing up anymore. Took some googling and dead-ends to find the right place. |
|
The DevTools team has engaged us about separating v8-inspector from Blink and making a package that we could use. This would allow anyone to open Chrome, browse to
My main concern are the integration points. While many of them can be done in native, which makes the conditional practically a performance noop, we will have to add a conditional in @paulirish listed some of the features that would be included: #2546 (comment) I'm unsure of how this would conflict, or if it would conflict, with the work @nodejs/tracing is doing. @ofrobots Do you have any feedback here? |
|
I can't make it today, let me know if there is anything you need from the On Wednesday, September 2, 2015, Trevor Norris [email protected]
|
|
@trevnorris I don't see much conflict between v8-inspector and trace-event. Blink already uses both trace-event and DevTools. |
|
The TSC call was yesterday? 😕 |
|
@mscdex I think that's just a typo. |
|
@mscdex sorry, dates are hard .. I always have to wind back by a day when I do these cause I'm a day ahead, I obviously wound back by two! @jkrems: yes, we've switched to being more timely now we have everything in place, the last minutes were merged with a soundcloud link in it and I'm going to try and be quicker in future in putting in the PRs. If you look in the doc/tsc-minutes/ directory you'll see SoundCloud links on all of those. |
|
@rvagg The thing is - the meeting issues are easy to find (for me at least) but even after you told me that the meeting notes were merged with the soundcloud link, I wasn't able to find them (without cheating and using the exact directory path in your comment). E.g. Google only leads to https://nodejs.org/en/foundation/tsc/minutes/. I think just adding a short "Meetings notes will be made available in |
|
Was confirmed that there's no need to add async stack trace support from the beginning: #2546 (comment) |
|
@jkrems I'll try and keep that in mind for next week, feel free to hassle me if I've forgotten tho! |
rvagg
changed the title
|
https://soundcloud.com/node-foundation/tsc-meeting-2015-09-02 is audio for this meeting, PRing in the minutes now |
Note that we already expose tracing over the remote debugging protocol. DevTools Timeline panel is implemented based on that. If it makes sense for Node.js too we can consider adding it to v8-inspector. The protocol implementation for tracing domain is fairly simple. |
|
@rvagg Can this be closed now? |
Time
UTC Wed 02-Sep-15 20:00:
Or in your local time:
Links
Agenda
Extracted from tsc-agenda labelled issues and pull requests from the nodejs org prior to meeting.
nodejs/node
nodejs/build
Invited
Notes
The agenda comes from issues labelled with
tsc-agendaacross all of the repositories in the nodejs org. Please label any additional issues that should be on the agenda before the meeting starts. I'm using a tool to fetch the list so it's not a big deal to collate.Joining the meeting
Uberconference; participants should have the link & numbers, contact me if you don't.
The text was updated successfully, but these errors were encountered: