Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate flaky parallel/test-pipe-unref #16875

Closed
Trott opened this issue Nov 8, 2017 · 0 comments
Closed

investigate flaky parallel/test-pipe-unref #16875

Trott opened this issue Nov 8, 2017 · 0 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests.

Comments

@Trott
Copy link
Member

Trott commented Nov 8, 2017

  • Version: 10.0.0-pre
  • Platform: freebsd10-64
  • Subsystem: test

https://ci.nodejs.org/job/node-test-commit-freebsd/13071/nodes=freebsd10-64/console:

not ok 1219 parallel/test-pipe-unref
  ---
  duration_ms: 1.978
  severity: fail
  stack: |-
    assert.js:42
      throw new errors.AssertionError({
      ^
    
    AssertionError [ERR_ASSERTION]: function should not have been called
        at Timeout.mustNotCall [as _onTimeout] (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/common/index.js:573:12)
        at ontimeout (timers.js:478:11)
        at Timer.unrefdHandle (timers.js:598:5)
@Trott Trott added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Nov 8, 2017
@mscdex mscdex added net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests. labels Nov 8, 2017
@apapirovski apapirovski mentioned this issue Jan 2, 2018
Closed
3 tasks
MylesBorins pushed a commit that referenced this issue Jan 8, 2018
@apapirovski @MylesBorins
test: fix flaky test-pipe-unref
ec9f361 
PR-URL: #17950
Fixes: #16875
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this issue Jan 9, 2018
@apapirovski @MylesBorins
test: fix flaky test-pipe-unref
13febf0 
PR-URL: #17950
Fixes: #16875
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this issue Jan 9, 2018
@apapirovski @MylesBorins
test: fix flaky test-pipe-unref
3399e8a 
PR-URL: #17950
Fixes: #16875
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this issue Jan 24, 2018
@apapirovski @MylesBorins
test: fix flaky test-pipe-unref
e9ece91 
PR-URL: #17950
Fixes: #16875
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this issue Jan 24, 2018
@apapirovski @MylesBorins
test: fix flaky test-pipe-unref
9fcf4d0 
PR-URL: #17950
Fixes: #16875
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this issue Feb 11, 2018
@apapirovski @MylesBorins
test: fix flaky test-pipe-unref
193844f 
PR-URL: #17950
Fixes: #16875
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this issue Feb 12, 2018
@apapirovski @MylesBorins
test: fix flaky test-pipe-unref
2265ae2 
PR-URL: #17950
Fixes: #16875
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this issue Feb 13, 2018
@apapirovski @MylesBorins
test: fix flaky test-pipe-unref
0c3f23e 
PR-URL: #17950
Fixes: #16875
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix flaky test-pipe-unref apapirovski/node
2 participants
@mscdex @Trott