Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible regression in RegExp.prototype.flags #16449

Closed
tanepiper opened this issue Oct 24, 2017 · 3 comments
Closed

Possible regression in RegExp.prototype.flags #16449

tanepiper opened this issue Oct 24, 2017 · 3 comments
Labels
v8 engine Issues and PRs related to the V8 dependency.

Comments

@tanepiper
Copy link

I spotted this on http://node.green/#ES2015-misc-Proxy--internal--get--calls-RegExp-prototype-flags

It appears the tests for RegExp.prototype.flags have been failing but has been failing since 8.3.0
@apapirovski
Copy link
Contributor

It's an issue with the test case because it doesn't account for the possibility of additional flags existing, such as dotAll which is currently available in V8.

@apapirovski
Copy link
Contributor

/cc @williamkapke

@mscdex mscdex added the v8 engine Issues and PRs related to the V8 dependency. label Oct 24, 2017
@williamkapke williamkapke mentioned this issue Oct 24, 2017
Closed
@williamkapke
Copy link
Contributor

I opened an issue to get this fixed. Thanks for pointing it out!
compat-table/compat-table#1208

(No Node core issue)

ljharb added a commit to ljharb/RegExp.prototype.flags that referenced this issue Oct 25, 2017
@ljharb
[New] add support for dotAll regex flag.
6a9003c 
Per nodejs/node#16449
ljharb added a commit to ljharb/RegExp.prototype.flags that referenced this issue Oct 25, 2017
@ljharb
[New] add support for dotAll regex flag.
fcbd64f 
Per nodejs/node#16449
This was referenced May 13, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@apapirovski @mscdex @tanepiper @williamkapke @joyeecheung