Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fatal error C1128 when building a debug build with VS2015 #16288

Closed
seishun opened this issue Oct 18, 2017 · 0 comments
Closed

fatal error C1128 when building a debug build with VS2015 #16288

seishun opened this issue Oct 18, 2017 · 0 comments
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.

Comments

@seishun
Copy link
Contributor

seishun commented Oct 18, 2017

  • Version: master
  • Platform: Windows 7 64-bit
  • Subsystem: build

With Visual Studio 2015, vcbuild debug results in the following error:

<...>\node\deps\v8\src\code-stub-assembler.cc : fatal error C1128: number of sections exceeded object file format limit: compile with /bigobj [<...>\node\deps\v8\src\v8_base_3.vcxproj]

If anyone from @nodejs/platform-windows can reproduce, I'll submit a PR adding /bigobj.
@seishun seishun added windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. labels Oct 18, 2017
@seishun seishun mentioned this issue Oct 18, 2017
Closed
2 tasks
MylesBorins pushed a commit that referenced this issue Oct 23, 2017
@seishun @MylesBorins
build, windows: use /bigobj for debug builds
152ca1e 
PR-URL: #16289
Fixes: #16288
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
addaleax pushed a commit to addaleax/ayo that referenced this issue Oct 23, 2017
@seishun @addaleax
build, windows: use /bigobj for debug builds
2846dbe 
PR-URL: nodejs/node#16289
Fixes: nodejs/node#16288
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this issue Oct 26, 2017
@seishun @addaleax
build, windows: use /bigobj for debug builds
4a43834 
PR-URL: nodejs/node#16289
Fixes: nodejs/node#16288
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this issue Nov 16, 2017
@seishun @MylesBorins
build, windows: use /bigobj for debug builds
231c8fa 
PR-URL: #16289
Fixes: #16288
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this issue Nov 21, 2017
@seishun @MylesBorins
build, windows: use /bigobj for debug builds
8e996da 
PR-URL: #16289
Fixes: #16288
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this issue Nov 28, 2017
@seishun @MylesBorins
build, windows: use /bigobj for debug builds
fc2ab06 
PR-URL: #16289
Fixes: #16288
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this issue Dec 7, 2017
@seishun @addaleax
build, windows: use /bigobj for debug builds
f2c9078 
PR-URL: nodejs/node#16289
Fixes: nodejs/node#16288
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build, windows: use /bigobj for debug builds
1 participant
@seishun