-
Notifications
You must be signed in to change notification settings - Fork 30.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
crypto: support --use-system-ca on Windows
This patch adds support for --use-system-ca on Windows. Currently this only supports Root CA certificates under the current user, with support for other certificates (matching Chromium's policy) as WIP.
- Loading branch information
1 parent
8fdaad7
commit dc737dd
Showing
6 changed files
with
254 additions
and
51 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| // Flags: --use-system-ca | ||
|
|
||
| import * as common from '../common/index.mjs'; | ||
| import assert from 'node:assert/strict'; | ||
| import https from 'node:https'; | ||
| import fixtures from '../common/fixtures.js'; | ||
| import { it, beforeEach, afterEach, describe } from 'node:test'; | ||
| import { once } from 'events'; | ||
|
|
||
| if (!common.isMacOS && !common.isWindows) { | ||
| common.skip('--use-system-ca is only supported on macOS and Windows'); | ||
| } | ||
|
|
||
| if (!common.hasCrypto) { | ||
| common.skip('requires crypto'); | ||
| } | ||
|
|
||
| // To run this test, the system needs to be configured to trust | ||
| // the CA certificate first (which needs an interactive GUI approval, e.g. TouchID): | ||
| // On macOS: | ||
| // 1. To add the certificate: | ||
| // $ security add-trusted-cert \ | ||
| // -k /Users/$USER/Library/Keychains/login.keychain-db \ | ||
| // test/fixtures/keys/fake-startcom-root-cert.pem | ||
| // 2. To remove the certificate: | ||
| // $ security delete-certificate -c 'StartCom Certification Authority' \ | ||
| // -t /Users/$USER/Library/Keychains/login.keychain-db | ||
| // | ||
| // On Windows: | ||
| // 1. To add the certificate in PowerShell (remember the thumbprint printed): | ||
| // $ Import-Certificate -FilePath .\test\fixtures\keys\fake-startcom-root-cert.cer \ | ||
| // -CertStoreLocation Cert:\CurrentUser\Root | ||
| // 2. To remove the certificate by the thumbprint: | ||
| // $ $thumbprint = (Get-ChildItem -Path Cert:\CurrentUser\Root | \ | ||
| // Where-Object { $_.Subject -match "StartCom Certification Authority" }).Thumbprint | ||
| // $ Remove-Item -Path "Cert:\CurrentUser\Root\$thumbprint" | ||
| const handleRequest = (req, res) => { | ||
| const path = req.url; | ||
| switch (path) { | ||
| case '/hello-world': | ||
| res.writeHead(200); | ||
| res.end('hello world\n'); | ||
| break; | ||
| default: | ||
| assert(false, `Unexpected path: ${path}`); | ||
| } | ||
| }; | ||
|
|
||
| describe('use-system-ca', function() { | ||
| let server; | ||
|
|
||
| beforeEach(async function() { | ||
| server = https.createServer({ | ||
| key: fixtures.readKey('agent8-key.pem'), | ||
| cert: fixtures.readKey('agent8-cert.pem'), | ||
| }, handleRequest); | ||
| server.listen(0); | ||
| await once(server, 'listening'); | ||
| }); | ||
|
|
||
| it('can connect successfully with a trusted certificate', async function() { | ||
| await fetch(`https://localhost:${server.address().port}/hello-world`); | ||
| }); | ||
|
|
||
| afterEach(async function() { | ||
| server?.close(); | ||
| }); | ||
| }); |