fixup! src: implement whatwg's URLPattern spec

nodejs · Jan 27, 2025 · 676ee51 · 676ee51
1 parent 71e1e9e
commit 676ee51
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/src/node_url_pattern.cc b/src/node_url_pattern.cc
@@ -182,7 +182,7 @@ void URLPattern::New(const FunctionCallbackInfo<Value>& args) {
       base_url = base_url_buffer.ToString();
     } else if (args[1]->IsObject()) {
       CHECK(!options.has_value());
-      options = URLPatternOptions::FromJsObject(env, args[0].As<Object>());
+      options = URLPatternOptions::FromJsObject(env, args[1].As<Object>());
       if (!options) {
         THROW_ERR_INVALID_ARG_TYPE(env, "options.ignoreCase must be a boolean");
         return;

diff --git a/test/wpt/status/urlpattern.json b/test/wpt/status/urlpattern.json
@@ -18,9 +18,7 @@
         "Pattern: [{\"hostname\":\"bad\\\\\\\\hostname\"}] Inputs: undefined",
         "Pattern: [{\"hostname\":\"bad\\nhostname\"}] Inputs: undefined",
         "Pattern: [{\"hostname\":\"bad\\rhostname\"}] Inputs: undefined",
-        "Pattern: [{\"hostname\":\"bad\\thostname\"}] Inputs: undefined",
-        "Pattern: [{\"pathname\":\"/foo/bar\"},{\"ignoreCase\":true}] Inputs: [{\"pathname\":\"/FOO/BAR\"}]",
-        "Pattern: [\"https://example.com:8080/foo?bar#baz\",{\"ignoreCase\":true}] Inputs: [{\"pathname\":\"/FOO\",\"search\":\"BAR\",\"hash\":\"BAZ\",\"baseURL\":\"https://example.com:8080\"}]"
+        "Pattern: [{\"hostname\":\"bad\\thostname\"}] Inputs: undefined"
       ]
     }
   },
@@ -34,9 +32,7 @@
         "Pattern: [{\"hostname\":\"bad\\\\\\\\hostname\"}] Inputs: undefined",
         "Pattern: [{\"hostname\":\"bad\\nhostname\"}] Inputs: undefined",
         "Pattern: [{\"hostname\":\"bad\\rhostname\"}] Inputs: undefined",
-        "Pattern: [{\"hostname\":\"bad\\thostname\"}] Inputs: undefined",
-        "Pattern: [{\"pathname\":\"/foo/bar\"},{\"ignoreCase\":true}] Inputs: [{\"pathname\":\"/FOO/BAR\"}]",
-        "Pattern: [\"https://example.com:8080/foo?bar#baz\",{\"ignoreCase\":true}] Inputs: [{\"pathname\":\"/FOO\",\"search\":\"BAR\",\"hash\":\"BAZ\",\"baseURL\":\"https://example.com:8080\"}]"
+        "Pattern: [{\"hostname\":\"bad\\thostname\"}] Inputs: undefined"
       ]
     }
   }