-
Notifications
You must be signed in to change notification settings - Fork 30.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
tools: use bundled npm in update scripts
The scripts `./tools/update-babel-eslint.sh` and `./tools/update-eslint.sh` are relying on the version of `npm` found in the local-defined `$PATH` env. This changeset proposes to modify these scripts to run the version of npm bundled in the current branch (found at `./deps/npm`) - in order to: a) Standardize the version of npm that should be use to install these deps, avoids the pitfall of having an inadverted user run these scripts with an unsupported/incompatible npm version. b) Given that npm7 has a different install algorithm than npm6 that takes into account and install peer dependencies, it might be a safer choice to ensure what version of npm should be use during this transitional period in which users might still have npm6 by default in their local system. c) Avoids the possible extra churn of having different resulting files being shuffled around between installs due to usage of a disparate version of the npm cli.
- Loading branch information
Showing
2 changed files
with
20 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,24 +2,27 @@ | |
|
||
# Shell script to update babel-eslint in the source tree to the latest release. | ||
|
||
# Depends on npm, npx, and node being in $PATH. | ||
|
||
# This script must be be in the tools directory when it runs because it uses | ||
# $0 to determine directories to work in. | ||
|
||
cd "$( dirname "${0}" )" || exit | ||
rm -rf node_modules/@babel | ||
mkdir babel-eslint-tmp | ||
cd babel-eslint-tmp || exit | ||
npm init --yes | ||
|
||
npm install --global-style --no-bin-links --production --no-package-lock @babel/core @babel/eslint-parser@latest @babel/plugin-syntax-class-properties@latest @babel/plugin-syntax-top-level-await@latest | ||
ROOT="$PWD/../.." | ||
[ -z "$NODE" ] && NODE="$ROOT/out/Release/node" | ||
[ -x "$NODE" ] || NODE=`command -v node` | ||
NPM="$ROOT/deps/npm" | ||
|
||
"$NODE" "$NPM" init --yes | ||
"$NODE" "$NPM" install --global-style --no-bin-links --production --no-package-lock @babel/core @babel/eslint-parser@latest @babel/plugin-syntax-class-properties@latest @babel/plugin-syntax-top-level-await@latest | ||
|
||
# Use dmn to remove some unneeded files. | ||
npx [email protected] -f clean | ||
"$NODE" "$NPM" exec -- [email protected] -f clean | ||
# Use removeNPMAbsolutePaths to remove unused data in package.json. | ||
# This avoids churn as absolute paths can change from one dev to another. | ||
npx [email protected] . | ||
"$NODE" "$NPM" exec -- [email protected] . | ||
|
||
cd .. | ||
mv babel-eslint-tmp/node_modules/@babel node_modules/@babel | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,8 +2,6 @@ | |
|
||
# Shell script to update ESLint in the source tree to the latest release. | ||
|
||
# Depends on npm, npx, and node being in $PATH. | ||
|
||
# This script must be in the tools directory when it runs because it uses the | ||
# script source file path to determine directories to work in. | ||
|
||
|
@@ -12,16 +10,22 @@ rm -rf node_modules/eslint node_modules/eslint-plugin-markdown | |
( | ||
mkdir eslint-tmp | ||
cd eslint-tmp || exit | ||
npm init --yes | ||
|
||
npm install --global-style --no-bin-links --production --no-package-lock eslint@latest | ||
npm install --global-style --no-bin-links --production --no-package-lock eslint-plugin-markdown@latest | ||
ROOT="$PWD/../.." | ||
[ -z "$NODE" ] && NODE="$ROOT/out/Release/node" | ||
[ -x "$NODE" ] || NODE=`command -v node` | ||
NPM="$ROOT/deps/npm" | ||
|
||
"$NODE" "$NPM" init --yes | ||
|
||
"$NODE" "$NPM" install --global-style --no-bin-links --production --no-package-lock eslint@latest | ||
"$NODE" "$NPM" install --global-style --no-bin-links --production --no-package-lock eslint-plugin-markdown@latest | ||
|
||
# Use dmn to remove some unneeded files. | ||
npx [email protected] -f clean | ||
"$NODE" "$NPM" exec -- [email protected] -f clean | ||
# Use removeNPMAbsolutePaths to remove unused data in package.json. | ||
# This avoids churn as absolute paths can change from one dev to another. | ||
npx [email protected] . | ||
"$NODE" "$NPM" exec -- [email protected] . | ||
) | ||
|
||
mv eslint-tmp/node_modules/eslint node_modules/eslint | ||
|