path: resolve() doesn't normalize drive letter on Windows

[mrfabbri]

Calling resolve() on Windows (in Node v0.11.0+) result in a path where drive
letter case isn't always lowercase (e.g. for a relative path like '.') while
normalize() always returns a path with a lower case drive letter.
This eventually breaks comparisons between results of resolve() and
join() (which relies on normalize()) for the same path.

Fixes #7031 also resolves #7806

[mrfabbri]

PS: First node contribution. CLA signed.

[Fishrock123]

@mrfabbri just fyi, the CLA is no longer required: f6ba61b

[mrfabbri]

@Fishrock123 thanks, missed that.

[mgol]

I guess this may be the fix for #7806?

This lack of normalizing can completely break builds on Windows in hard to debug ways...

[mrfabbri]

@mzgol yes, updated the pull request message accordingly.

[mgol]

@mrfabbri Can you update commit message as well?

[jonschlinkert]

#7806 is a bug. this creates another bug. please explain the reasoning on this. what platform do you use @mrfabbri?

[mrfabbri]

@jonschlinkert the problem is specific to Windows (as the changes in the PR, affecting a code path relative to Windows): on the documentation for path.resolve() is reported that "the resulting path is normalized" and starting from 0.11.0 (see #a05f973 ) path.normalize() behaviour on Windows is to lowercase drive letters while path.resolve() leaves the drive letter unchanged so a call to path.resolve() for the same path can result in a drive letter lower or upper case depending on how you invoked it.

The reasoning was to port the same behaviour of path.normalize() (relative to drive letter case) to path.resolve(). What bug does the PR introduce?

As a side note, I experienced the bug while testing a node-webkit (which uses node v0.11.x) app on Windows.

[jasnell]

@orangemocha ... thoughts?

[orangemocha]

I believe this was fixed in f6e5740. The behavior was later changed in 016e084, to avoid modifying the case of the drive letter.