Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Intl: endianness problems? #9046

Closed
srl295 opened this issue Jan 16, 2015 · 1 comment
Closed

Intl: endianness problems? #9046

srl295 opened this issue Jan 16, 2015 · 1 comment

Comments

@srl295
Copy link
Member

srl295 commented Jan 16, 2015

https://github.com/srl295/node/issues/23#issuecomment-70295036 has identified a problem with the v0.12 with respect to cross endianness. The branch https://github.com/srl295/node/tree/srl-v0.12-srl295-23 seems to solve them but may be too drastic (the risk is, it may increase disk footprint on NON cross builds).

The core issue is this:

  • to save disk, we don't include ICU's codepage conversion, IDNA, etc code.
  • however, to swap endianness (LE to BE) we NEED the above code to properly swap ICU data. ICU bug #11046

Options:

  • Build ICU twice - once just to swap, once for the target.
  • Figure out how to delete the codepage conversion, etc. while swapping?
  • Delete the unused data first, THEN swap

Adding this here since @misterdjules has recommended keeping issues here. FYI @sxa555

@misterdjules misterdjules added this to the 0.12.1 milestone Jan 19, 2015
@srl295
Copy link
Member Author

srl295 commented Jan 22, 2015

Summary - https://github.com/srl295/node/compare/srl-v0.12-srl295-23 seems to fix this as far as we can tell. Could be put behind a conditional to keep footprint down a little bit.

srl295 added a commit to srl295/node-v0.x-archive that referenced this issue Jan 24, 2015
ICU can't "swap endianness" if its conversion, etc code is removed.
We don't want this code in node, but it's needed for the tools.

May affect 'target' inadvertently - to be analyzed.
Basically this is nodejs#9046 but also blocks nodejs#8996
@misterdjules misterdjules modified the milestones: 0.12.3, 0.12.2 Apr 1, 2015
@misterdjules misterdjules modified the milestones: 0.12.3, 0.12.4 May 14, 2015
@misterdjules misterdjules modified the milestones: 0.12.4, 0.12.5 May 25, 2015
@misterdjules misterdjules modified the milestones: 0.12.5, 0.12.6 Jun 22, 2015
@misterdjules misterdjules modified the milestones: 0.12.6, 0.12.7, 0.12.8 Jul 6, 2015
@Trott Trott closed this as completed Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants