ci: switch to GitHub Actions #2210
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,66 @@ | ||||||
| # TODO: Line 20, enable python-version: 3.5 | ||||||
| # TODO: Line 69, enable pytest --doctest-modules | ||||||
|
There was a problem hiding this comment. This seems quite important to me. What are the remaining blockers? |
||||||
|
|
||||||
| name: Tests | ||||||
cclauss marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
|
|
||||||
| on: | ||||||
| push: | ||||||
| branches: | ||||||
| - master | ||||||
| pull_request: | ||||||
| branches: | ||||||
| - master | ||||||
|
There was a problem hiding this comment.
Suggested change
I usually run tests on all pull requests on all branches. Is there a reason to avoid doing that? |
||||||
|
|
||||||
| jobs: | ||||||
| test: | ||||||
| strategy: | ||||||
| fail-fast: false | ||||||
| matrix: | ||||||
| node: [10.x, 12.x, 14.x] | ||||||
| python: [3.6, 3.7, 3.8] | ||||||
|
There was a problem hiding this comment. Please do just one test run on There was a problem hiding this comment. tested it in cc9942e and it passes (only the doctest-modules fails so I reverted it back to a TODO) |
||||||
| os: [macos-latest, ubuntu-latest, windows-latest] | ||||||
| runs-on: ${{ matrix.os }} | ||||||
| steps: | ||||||
| - name: Checkout Repository | ||||||
| uses: actions/checkout@v2 | ||||||
| - name: Use Node.js ${{ matrix.node }} | ||||||
| uses: actions/setup-node@v1 | ||||||
| with: | ||||||
| node-version: ${{ matrix.node }} | ||||||
| - name: Use Python ${{ matrix.python }} | ||||||
| uses: actions/setup-python@v2 | ||||||
| with: | ||||||
| python-version: ${{ matrix.python }} | ||||||
| env: | ||||||
| PYTHON_VERSION: ${{ matrix.python }} | ||||||
| - name: Install Dependencies | ||||||
| run: | | ||||||
| npm install --no-progress | ||||||
| pip install flake8 pytest | ||||||
| - name: Lint python | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| if: matrix.os == 'ubuntu-latest' | ||||||
| run: | | ||||||
| # stop the build if there are Python syntax errors or undefined names | ||||||
| flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics | ||||||
| # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide | ||||||
| flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics | ||||||
| - name: Run node tests (Linux and macOS) | ||||||
| if: matrix.os != 'windows-latest' | ||||||
| run: | | ||||||
| npm test | ||||||
| - name: Run python tests (Linux and macOS) | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| if: matrix.os != 'windows-latest' | ||||||
| run: | | ||||||
| python -m pytest | ||||||
| - name: Run node tests (Windows) | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| if: matrix.os == 'windows-latest' | ||||||
| shell: bash | ||||||
| run: | | ||||||
| GYP_MSVS_VERSION=2015 GYP_MSVS_OVERRIDE_PATH="C:\\Dummy" npm test | ||||||
| - name: Run python tests (Windows) | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| if: matrix.os == 'windows-latest' | ||||||
| shell: bash | ||||||
| run: | | ||||||
| GYP_MSVS_VERSION=2015 GYP_MSVS_OVERRIDE_PATH="C:\\Dummy" python -m pytest | ||||||
| # - name: Run doctests with pytest | ||||||
| # run: pytest --doctest-modules | ||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that Py35 reaches end-of-life in less than two weeks, let's just remove support.
https://devguide.python.org/#status-of-python-branches