This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
napi: fix property string length #408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSLaguana
approved these changes
Oct 2, 2017
bnoordhuis
reviewed
Oct 2, 2017
src/node_api_jsrt.cc
Outdated
| @@ -783,10 +783,10 @@ napi_status napi_define_class(napi_env env, | |||
|
|
|||
| JsPropertyIdRef pid = nullptr; | |||
| JsValueRef prototype = nullptr; | |||
| CHECK_JSRT(JsCreatePropertyId("prototype", 10, &pid)); | |||
| CHECK_JSRT(JsCreatePropertyId("prototype", 9, &pid)); | |||
There was a problem hiding this comment.
Just a suggestion but you could use sizeof("prototype") - 1 as it's obviously correct and idiomatic. It's the style the code base uses elsewhere.
There was a problem hiding this comment.
@bnoordhuis sounds good.
|
Went a step further and created a macro.. well, in case we write |
MSLaguana
pushed a commit
that referenced
this pull request
Oct 2, 2017
PR-URL: #408 Reviewed-By: Jimmy Thomson <[email protected]>
|
Merged in 233d9dd |
MSLaguana
pushed a commit
to MSLaguana/node-chakracore
that referenced
this pull request
Oct 2, 2017
PR-URL: nodejs#408 Reviewed-By: Jimmy Thomson <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.