This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
ttd: adding ttd tracking logic to aliased_buffer #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @mrkmarron |
|
LGTM |
Whenever state modifications happen outside of JSRT API calls, we need to to track them to for TTD to correctly track state. This change updates aliased_buffer's SetValue() method to do the correct TTD tracking. PR-URL: nodejs#397 Reviewed-By: Mark Marron <[email protected]>
mike-kaufman
force-pushed
the
mkaufman-update-aliased-buffer-to-do-ttd-tracking
branch
from
b662842 to
b4d318e
Compare
mike-kaufman
deleted the
mkaufman-update-aliased-buffer-to-do-ttd-tracking
branch
MSLaguana
pushed a commit
to MSLaguana/node-chakracore
that referenced
this pull request
Sep 28, 2017
Whenever state modifications happen outside of JSRT API calls, we need to to track them to for TTD to correctly track state. This change updates aliased_buffer's SetValue() method to do the correct TTD tracking. PR-URL: nodejs#397 Reviewed-By: Mark Marron <[email protected]>
joaocgreis
added a commit
to joaocgreis/node-chakracore
that referenced
this pull request
Nov 2, 2017
chakra_tdd.h was added to the sources. This adds it to install.py to be included in the headers package. Refs: nodejs#397 Fixes: nodejs#417
4 tasks
joaocgreis
added a commit
that referenced
this pull request
Nov 9, 2017
chakra_tdd.h was added to the sources. This adds it to install.py to be included in the headers package. Refs: #397 Fixes: #417 PR-URL: #421 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Mike Kaufman <[email protected]>
kfarnung
pushed a commit
that referenced
this pull request
Jan 12, 2018
chakra_tdd.h was added to the sources. This adds it to install.py to be included in the headers package. Refs: #397 Fixes: #417 PR-URL: #421 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Mike Kaufman <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever state modifications happen outside of JSRT API calls, we need
to to track them to for TTD to correctly track state. This change
updates aliased_buffer's SetValue() method to do the correct TTD
tracking.
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
ttd