This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
Update README.md #149
Merged
Update README.md #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ### Issues | ||
|
|
||
| Please report all issues related to Node-ChakraCore on this separate |
There was a problem hiding this comment.
Nit: change this to "on our issues page"
| Check out this [Time-Travel Debugging](https://github.com/nodejs/node-chakracore/blob/xplat/TTD-README.md) page to learn how to get started with TTD on Node-ChakraCore with VSCode. | ||
|
|
||
| ### Node.js API (NAPI) | ||
| ChakraCore is also supporting the advancement of [ABI-Stable-Node](https://github.com/nodejs/abi-stable-node) project also called NAPI. The compatibility of native add-on Node module ecosystem is going to greatly improve across different node versions and also different Node VMs. |
There was a problem hiding this comment.
Nit: , before also called. Also, would the second sentence be better if stated as a goal? "The goal of this project is to ease the lives of native add-ons developers by providing Node a stable ABI that module authors can target, thus improving compatibility across disparate Node versions?
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated readme to high light the areas of focus and install instructions.