Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Commit

Permalink
src: fix build break for !NODE_USE_V8_PLATFORM
Browse files Browse the repository at this point in the history
`StartInspector` should return `bool` but there was signature
mismatch if not building for v8 platform i.e.
`!NODE_USE_V8_PLATFORM`.

I have submitted PR nodejs/node#8114 to fix this in
node repo.

PR-URL: #108
Reviewed-By: Sandeep Agarwal <[email protected]>
  • Loading branch information
kunalspathak committed Aug 17, 2016
1 parent 45ff9e9 commit a606f84
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/node.cc
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,9 @@ static struct {
void Initialize(int thread_pool_size) {}
void PumpMessageLoop(Isolate* isolate) {}
void Dispose() {}
void StartInspector(Environment *env, int port, bool wait) {
bool StartInspector(Environment *env, int port, bool wait) {
env->ThrowError("Node compiled with NODE_USE_V8_PLATFORM=0");
return false; // make compiler happy
}
#endif // !NODE_USE_V8_PLATFORM
} v8_platform;
Expand Down

0 comments on commit a606f84

Please sign in to comment.