chakrashim: Added missing API in v8.h

PR-URL: #108 Reviewed-By: Sandeep Agarwal <[email protected]>
nodejs · Aug 17, 2016 · 45ff9e9 · 45ff9e9
1 parent 913ea18
commit 45ff9e9
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/deps/chakrashim/include/v8-version.h b/deps/chakrashim/include/v8-version.h
@@ -34,7 +34,7 @@
 #define V8_MAJOR_VERSION 5
 #define V8_MINOR_VERSION 1
 #define V8_BUILD_NUMBER 281
-#define V8_PATCH_LEVEL 69
+#define V8_PATCH_LEVEL 80
 
 // Use 1 for candidates and 0 otherwise.
 // (Boolean macro values are not supported by all preprocessors.)

diff --git a/deps/chakrashim/include/v8.h b/deps/chakrashim/include/v8.h
@@ -1603,6 +1603,8 @@ class PropertyCallbackInfo {
   Local<Value> Data() const { return _data; }
   Local<Object> This() const { return _thisObject; }
   Local<Object> Holder() const { return _holder; }
+  // CHAKRA-TODO
+  bool ShouldThrowOnError() const { return true; }
   ReturnValue<T> GetReturnValue() const {
     return ReturnValue<T>(
       &(const_cast<PropertyCallbackInfo<T>*>(this)->_returnValue));

diff --git a/test/parallel/test-repl.js b/test/parallel/test-repl.js
@@ -389,7 +389,7 @@ function error_test() {
     // Avoid emitting stack trace
     { client: client_unix, send: 'a = 3.5e',
       expect: /^(?!\s+at\s)/gm },
-].filter((v) => !common.engineSpecificMessage(v)));
+  ].filter((v) => !common.engineSpecificMessage(v)));
 }
 
 function tcp_test() {