chakrashim: shimming new apis

nodejs · Jan 9, 2018 · 00e0d1b · 00e0d1b
1 parent a2e28d7
commit 00e0d1b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/deps/chakrashim/include/v8.h b/deps/chakrashim/include/v8.h
@@ -2895,6 +2895,8 @@ class V8_EXPORT Module {
   V8_WARN_UNUSED_RESULT bool Instantiate(Local<Context> context,
                                          ResolveCallback callback);
 
+  Maybe<bool> InstantiateModule(Local<Context> context,
+                                ResolveCallback callback);
   /**
    * ModuleEvaluation
    *

diff --git a/deps/chakrashim/src/v8module.cc b/deps/chakrashim/src/v8module.cc
@@ -46,6 +46,11 @@ namespace v8 {
       return false;
   }
 
+  Maybe<bool> Module::InstantiateModule(Local<Context> context,
+    ResolveCallback callback) {
+      return Just(false);  
+  }
+
   MaybeLocal<Value> Module::Evaluate(Local<Context> context) {
       // CHAKRA-TODO: Find a way to support es6 modules under
       // the constraints of the node implementation