Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable experimental testing in ci-win.yml #1548

Merged
merged 1 commit into from
Aug 2, 2024
Merged

chore: enable experimental testing in ci-win.yml #1548

merged 1 commit into from
Aug 2, 2024

Conversation

KevinEady
Copy link
Contributor

Closes: #1516

@KevinEady
Copy link
Contributor Author

The pull-request build for Node.js CI Windows Platform shows both standard and experimental.

We see on a standard run:

Testing with Node-API Version '9'.

We see on an experimental run:

Testing with Node-API Version '2147483647'.

@KevinEady KevinEady mentioned this pull request Jul 29, 2024
Merged
3 tasks
mhdawson
mhdawson approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit 66cbb58 into nodejs:main Aug 2, 2024
47 checks passed
@KevinEady KevinEady deleted the enable-ci-win-experimental branch August 2, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@gabrielschulhof gabrielschulhof gabrielschulhof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Turn on experimental in ci-win.yml
3 participants
@KevinEady @gabrielschulhof @mhdawson