Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook for manifest loading #44

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
Co-authored-by: Jacob Smith <[email protected]>
  • Loading branch information
arcanis and JakobJingleheimer authored Nov 18, 2021
commit fa0c8cfa86f643ef8dbf253e39a62d7db9a8961d
2 changes: 1 addition & 1 deletion doc/design/proposal-chaining-iterative.md
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ LoadManifest hooks would have the following signature:

```ts
export async function readFile(
url: string, // A URL that point to a location; whether the file
url: string, // A URL pointing to a location; whether the file
// exists or not isn't guaranteed
interimResult: { // result from the previous hook
data: string | ArrayBuffer | TypedArray | null, // The content of the
Expand Down
2 changes: 1 addition & 1 deletion doc/design/proposal-chaining-middleware.md
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ Load hooks would have the following signature:

```ts
export async function readFile(
url: string, // A URL that point to a location; whether the file
url: string, // A URL pointing to a location; whether the file
// exists or not isn't guaranteed
context: {
conditions = string[], // Export conditions of the relevant `package.json`
Expand Down