-
Notifications
You must be signed in to change notification settings - Fork 39
feat: Added workflow to protect content #320
Conversation
alexandrtovmach
commented
Apr 22, 2020
- We need to set up GITHUB_TOKEN to secrets (I haven't admin rights in repo to do by my own)
- Probably I need to make a few iterations to debug and test workflow
Hmm... but I can test it with direct PR to |
Think the problem with this is that pull requests from forks won't have access to secrets either way |
Is not a fork;) |
No, but if you're trying to prevent pull requests coming from forks, I don't think the Action will be able to access when triggered from forks |
Co-Authored-By: Nick Schonning <[email protected]>
@nschonni Are you sure that this limitation applies to public repos?
From GitHub Action docs:
|
on: | ||
pull_request: | ||
paths: | ||
- 'content/**' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would allow changes to the English content like when adding a new version
- 'content/**' | |
- 'content/**' | |
- "!content/*/en-US/**" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would allow changes to the English content like when adding a new version
All content inside content/
must be changed automatically with bots (@nodejs-crowdin and @github-actions).
Workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't happen for new Node versions through the sync right now, it relies on the folder being adding in addtion to the package.json change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on: | ||
pull_request: | ||
paths: | ||
- 'content/**' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would allow changes to the English content like when adding a new version
All content inside content/
must be changed automatically with bots (@nodejs-crowdin and @github-actions).
Workflow
Co-authored-by: Nick Schonning <[email protected]> Co-authored-by: Tiago Danin <[email protected]>
It's not merged yet, because related to #313 |
Blocker PR is already merged |