This repository has been archived by the owner on Jul 6, 2018. It is now read-only.
src: make node-http2-core files consistent #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
hmm... after applying this I get an error building. Will try again later to see what is happening. |
This might be an incorrect change but the naming looks to be a little different for these files and wanted to bring it up. Feel free to close if this is indeed correct.
|
@jasnell Sorry about that, I've rebased this and it is failing for me as well. Not sure how I missed that yesterday. Will push a fix shortly. |
|
Landed! |
jasnell
pushed a commit
that referenced
this pull request
May 7, 2017
This might be an incorrect change but the naming looks to be a little different for these files and wanted to bring it up. Feel free to close if this is indeed correct. PR-URL: #74 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
May 19, 2017
This might be an incorrect change but the naming looks to be a little different for these files and wanted to bring it up. Feel free to close if this is indeed correct. PR-URL: #74 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
May 31, 2017
This might be an incorrect change but the naming looks to be a little different for these files and wanted to bring it up. Feel free to close if this is indeed correct. PR-URL: #74 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell
pushed a commit
to jasnell/http2-1
that referenced
this pull request
Jun 22, 2017
This might be an incorrect change but the naming looks to be a little different for these files and wanted to bring it up. Feel free to close if this is indeed correct. PR-URL: nodejs#74 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell
pushed a commit
to jasnell/http2-1
that referenced
this pull request
Jul 10, 2017
This might be an incorrect change but the naming looks to be a little different for these files and wanted to bring it up. Feel free to close if this is indeed correct. PR-URL: nodejs#74 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell
pushed a commit
to jasnell/http2-1
that referenced
this pull request
Jul 14, 2017
This might be an incorrect change but the naming looks to be a little different for these files and wanted to bring it up. Feel free to close if this is indeed correct. PR-URL: nodejs#74 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be an incorrect change but the naming looks to be a little
different for these files and wanted to bring it up. Feel free to close
if this is indeed correct.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src