Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

label: mark all quic change as dont-land-v14.x #267

Merged
merged 1 commit into from
Jul 29, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions lib/node-labels.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ const subSystemLabelsMap = new Map([
[/^src\/node_report/, ['c++', 'report']],
[/^src\/node_wasi/, ['c++', 'wasi']],
[/^src\/node_worker/, ['c++', 'worker']],
[/^src\/quic\/*/, ['c++', 'quic']],
[/^src\/node_bob*/, ['c++', 'quic']],
[/^src\/quic\/*/, ['c++', 'quic', 'dont-land-on-v14.x', 'dont-land-on-v12.x']],
[/^src\/node_bob*/, ['c++', 'quic', 'dont-land-on-v14.x', 'dont-land-on-v12.x']],

// don't label python files as c++
[/^src\/.+\.py$/, 'lib / src'],
Expand Down Expand Up @@ -80,8 +80,8 @@ const subSystemLabelsMap = new Map([
[/^deps\/uvwasi\//, 'wasi'],
[/^deps\/nghttp2\/nghttp2\.gyp/, ['build', 'http2', 'dont-land-on-v6.x']],
[/^deps\/nghttp2\//, ['http2', 'dont-land-on-v6.x']],
[/^deps\/ngtcp2\//, 'quic'],
[/^deps\/nghttp3\//, 'quic'],
[/^deps\/ngtcp2\//, 'quic', 'dont-land-on-v14.x', 'dont-land-on-v12.x'],
[/^deps\/nghttp3\//, 'quic', 'dont-land-on-v14.x', 'dont-land-on-v12.x'],
[/^deps\/([^/]+)/, '$1'],

/* JS subsystems */
Expand All @@ -98,7 +98,7 @@ const subSystemLabelsMap = new Map([
[/^lib\/worker_threads.js$/, ['worker']],
[/^lib\/internal\/url\.js$/, ['url-whatwg']],
[/^lib\/internal\/modules\/esm/, 'ES Modules'],
[/^lib\/internal\/quic\/*/, ['quic']],
[/^lib\/internal\/quic\/*/, ['quic', 'dont-land-on-v14.x', 'dont-land-on-v12.x']],
// All other lib/ files map directly
[/^lib\/_(\w+)_\w+\.js?$/, '$1'], // e.g. _(stream)_wrap
[/^lib(\/internal)?\/(\w+)\.js?$/, '$2'], // other .js files
Expand Down Expand Up @@ -139,7 +139,7 @@ const exclusiveLabelsMap = new Map([
// considered a subsystem of sorts
[/^doc\/api\/n-api.md$/, ['doc', 'n-api']],
// quic
[/^doc\/api\/quic.md$/, ['doc', 'quic']],
[/^doc\/api\/quic.md$/, ['doc', 'quic', 'dont-land-on-v14.x', 'dont-land-on-v12.x']],
// add worker label to PRs that affect doc/api/worker_threads.md
[/^doc\/api\/worker_threads.md$/, ['doc', 'worker']],
// automatically tag JS subsystem-specific API doc changes
Expand Down