Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add gabrielschulhof to TSC #113

Merged
merged 1 commit into from
Sep 13, 2018
Merged

add gabrielschulhof to TSC #113

merged 1 commit into from
Sep 13, 2018

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 12, 2018

/ping @nodejs/tsc

cjihrig

This comment was marked as off-topic.

Sign in to view

addaleax

This comment was marked as off-topic.

Sign in to view

targos

This comment was marked as off-topic.

Sign in to view

MylesBorins

This comment was marked as off-topic.

Sign in to view

MylesBorins

This comment was marked as off-topic.

Sign in to view

@MylesBorins
Copy link
Contributor

Want to confirm this email is correct and working, I just attempted to email and got a delivery failure. Please dismiss this review if everything is fine

@mhdawson
Copy link
Member

Strange that is the email I've used to contact him in the past as well. Will try to validate.

mhdawson

This comment was marked as off-topic.

Sign in to view

@Trott
Copy link
Member Author

Trott commented Sep 12, 2018

/ping @gabrielschulhof on the email-correctness question.

@mhdawson
Copy link
Member

I sent email to Gabriel using the address and he responded back so I believe it is ok. Going to dismiss Myles review since he said it was ok and land.

@mhdawson mhdawson dismissed MylesBorins’s stale review September 13, 2018 14:43

Email seems ok, and Myles said it was ok to dismiss in that case.

@mhdawson mhdawson merged commit 50b6366 into nodejs:master Sep 13, 2018
@mhdawson
Copy link
Member

Should be live now.

uneoka0114 added a commit to uneoka0114/NodeJS-Email that referenced this pull request Jul 16, 2024
@uneoka0114
add gabrielschulhof to TSC (#113)
d315cc0 
PR-URL: nodejs/email#113
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@mhdawson mhdawson mhdawson approved these changes

@MylesBorins MylesBorins MylesBorins left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @MylesBorins @mhdawson @addaleax @targos @cjihrig