Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed new shfmt issue #790

Merged
merged 2 commits into from
Jun 18, 2018
Merged

Conversation

LaurentGoderre
Copy link
Member

No description provided.

@LaurentGoderre
Copy link
Member Author

ARG!!! shfmt and shellcheck are conflicting now....

@chorrell
Copy link
Contributor

Can we pin to a version of the shfmt image? I'd like to not be surprised by these kinds of changes in the future.

@LaurentGoderre
Copy link
Member Author

Had to find a syntax that pleased both validator and the regexp syntax.....

@LaurentGoderre
Copy link
Member Author

@chorrell the source repo doesn't seem to use versions or tags for their docker image

@LaurentGoderre
Copy link
Member Author

@chorrell can we merge since it passed all the tests?

@chorrell
Copy link
Contributor

Can we use the sha256 hash?

$ docker inspect --format='{{.RepoDigests}}' jamesmstone/shfmt 
[jamesmstone/shfmt@sha256:4eff05b54e87c11e8214848de3e5f4bb47a4241b99ac5c6554db5cc164015810]

@chorrell
Copy link
Contributor

This should work:

- docker run -it --rm -v "$(pwd)":/sh -w /sh jamesmstone/shfmt@sha256:4eff05b54e87c11e8214848de3e5f4bb47a4241b99ac5c6554db5cc164015810 -i 2 -l -w -ci .

I would really like to see this incorporated. The last thing we want is for some random change to shfmt (and in the scheme of things, trivial bash syntax issues) to hold up future releases.

@LaurentGoderre
Copy link
Member Author

Good point!

@LaurentGoderre
Copy link
Member Author

Done!

PeterDaveHello

This comment was marked as off-topic.

@LaurentGoderre
Copy link
Member Author

All tests are green, can we merge?

SimenB

This comment was marked as off-topic.

chorrell

This comment was marked as off-topic.

@LaurentGoderre LaurentGoderre merged commit 368e72d into nodejs:master Jun 18, 2018
@LaurentGoderre LaurentGoderre deleted the fix-shfmt branch June 18, 2018 17:02
@chorrell
Copy link
Contributor

Something for another pr maybe: One of the secure variables in your .travis.yml has an invalid format

@LaurentGoderre
Copy link
Member Author

Not sure that is true though, the variable actually work....

@chorrell
Copy link
Contributor

chorrell commented Jun 18, 2018

¯\_(ツ)_/¯

@LaurentGoderre
Copy link
Member Author

LaurentGoderre commented Jun 18, 2018

We can look into it though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants