-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed new shfmt issue #790
Conversation
ARG!!! shfmt and shellcheck are conflicting now.... |
Can we pin to a version of the shfmt image? I'd like to not be surprised by these kinds of changes in the future. |
063ca87
to
b9dc6bb
Compare
Had to find a syntax that pleased both validator and the regexp syntax..... |
@chorrell the source repo doesn't seem to use versions or tags for their docker image |
@chorrell can we merge since it passed all the tests? |
Can we use the sha256 hash?
|
This should work:
I would really like to see this incorporated. The last thing we want is for some random change to shfmt (and in the scheme of things, trivial bash syntax issues) to hold up future releases. |
Good point! |
Done! |
All tests are green, can we merge? |
Something for another pr maybe: |
Not sure that is true though, the variable actually work.... |
|
We can look into it though |
No description provided.