Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

chore: add INITIATIVE_PROCESS.md file #436

Merged
merged 2 commits into from
Jan 16, 2019

Conversation

lidoravitan
Copy link
Contributor

add documentation for initiative process setup, related to #374 issue.

Copy link
Contributor

@keywordnew keywordnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! 🎉

To make it easier for people to find and make use of, I'd suggest also linking to this file from the README, maybe within the Strategic Initiatives section.

@keywordnew
Copy link
Contributor

Closes #374


- [ ] Template for inclusion of the Node.js Code of Conduct (example)
- [ ] Template for CONTRIBUTING.md (example)
- [ ] Meeting minutes configuration (if needed – see this for the four kinds of templates)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [ ] Meeting minutes configuration (if needed – see this for the four kinds of templates)
- [ ] Meeting minutes configuration (if needed – see [this](https://github.com/nodejs/create-node-meeting-artifacts/tree/master/templates) for the four kinds of templates)

The link was broken.

@@ -0,0 +1,6 @@
# Initiative Setup Process

- [ ] Template for inclusion of the Node.js Code of Conduct (example)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [ ] Template for inclusion of the Node.js Code of Conduct (example)
- [ ] Template for inclusion of the Node.js Code of Conduct ([example](https://github.com/nodejs/community-committee/blob/master/CODE_OF_CONDUCT.md))

Link broken.

- [ ] Template for inclusion of the Node.js Code of Conduct (example)
- [ ] Template for CONTRIBUTING.md (example)
- [ ] Meeting minutes configuration (if needed – see this for the four kinds of templates)
- [ ] Add to the STRATEGIC-INITIATIVES.md list
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [ ] Add to the STRATEGIC-INITIATIVES.md list
- [ ] Add to the [STRATEGIC-INITIATIVES.md](https://github.com/nodejs/community-committee#strategic-initiatives) list

# Initiative Setup Process

- [ ] Template for inclusion of the Node.js Code of Conduct (example)
- [ ] Template for CONTRIBUTING.md (example)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [ ] Template for CONTRIBUTING.md (example)
- [ ] Template for CONTRIBUTING.md ([example](https://github.com/nodejs/i18n/blob/master/CONTRIBUTING.md))

@lidoravitan
Copy link
Contributor Author

@chowdhurian thanks for the review, your comments are very clear. can you review again?

Copy link
Contributor

@keywordnew keywordnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for addressing the comments 🎉

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keywordnew keywordnew merged commit 0e90cf4 into nodejs:master Jan 16, 2019
@keywordnew
Copy link
Contributor

Thanks for putting time and effort into the PR @lidoravitan 🏆

@lidoravitan
Copy link
Contributor Author

lidoravitan commented Jan 17, 2019

@chowdhurian Thank you for your support/mentoring it was very helpful, Hope to be more and more involved. 💚

actually, maybe I can open PR about "linking to this file from the README" if it necessary.

@keywordnew
Copy link
Contributor

Could be very helpful to link it from there 💯

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants