Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup: add packages that test streams #68

Merged
merged 1 commit into from
Feb 15, 2016

Conversation

MylesBorins
Copy link
Contributor

this commit adds the following packages to the lookup

  • vinyl
  • vinyl-fs
  • readable-stream
  • ftp
  • split2
  • throughv
  • duplexer2
  • bl
  • binary-csv
  • spdy
  • dicer
  • spdy-transport
  • sax
  • duplexify
  • pumpify
  • from2
  • flush-write-stream
  • jsonstream
  • csv-parser

Please feel free to submit more ideas and I'll add them to the list if they work. If they don't, we'll try and get them to 😄

/cc @jasnell @chrisdickinson @phated @nodejs/streams

@jasnell
Copy link
Member

jasnell commented Feb 3, 2016

LGTM
On Feb 2, 2016 3:39 PM, "Myles Borins" [email protected] wrote:

this commit adds the following packages to the lookup

  • vinyl
  • vinyl-fs
  • readable-stream

Please feel free to submit more ideas and I'll add them to the list if
they work. If they don't, we'll try and get them to [image: 😄]

/cc @jasnell https://github.com/jasnell @chrisdickinson
https://github.com/chrisdickinson @phated https://github.com/phated

@nodejs/streams https://github.com/orgs/nodejs/teams/streams

You can view, comment on, or merge this pull request online at:

#68
Commit Summary

  • lookup: add packages that test streams

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#68.

@rvagg
Copy link
Member

rvagg commented Feb 3, 2016

through2 if it's not in there is pretty heavily depended on even though it's fairly small

split2, throughv, duplexer2 test some interesting parts of streams

bl is heavily used and uses streams for some of its functions, is it in the list?

binary-split and binary-csv are also interesting use-cases worth poking at

@ronkorving
Copy link

I use spdy and dicer quite a bit.

@indutny
Copy link
Member

indutny commented Feb 3, 2016

spdy-transport is using streams quite actively, could be a nice addition.

@mafintosh
Copy link
Member

https://github.com/mafintosh/duplexify
https://github.com/mafintosh/pumpify

are pretty heavily relied on as well. if a module is using readable-stream internally instead of core streams will they still be tested?

@rvagg
Copy link
Member

rvagg commented Feb 3, 2016

if a module is using readable-stream internally instead of core streams will they still be tested?

I think we want a mixture of both

@danmactough
Copy link

https://github.com/isaacs/sax-js is pretty crucial to a lot of streaming XML parsing

@bcomnes
Copy link

bcomnes commented Feb 3, 2016

Its just a collection of what is mostly already listed here, but https://github.com/maxogden/mississippi

The missing importaint ones would be:

https://www.npmjs.com/package/from2
https://www.npmjs.com/package/flush-write-stream

@MylesBorins MylesBorins force-pushed the streams branch 3 times, most recently from 115c194 to a449e8b Compare February 5, 2016 22:26
@MylesBorins
Copy link
Contributor Author

a run of citgm in CI with these packages

https://ci.nodejs.org/job/thealphanerd-smoker/59/

@MylesBorins
Copy link
Contributor Author

Looks like failures for both bl and vinyl-fs

Going to run individual citgm's for each on to make debugging cleaner

bl: https://ci.nodejs.org/job/thealphanerd-smoker/60/
vinyl-fs: https://ci.nodejs.org/job/thealphanerd-smoker/61/

@ronkorving
Copy link

Oh, let's not forget jsonstream

@MylesBorins
Copy link
Contributor Author

One more round of citgm: https://ci.nodejs.org/job/thealphanerd-smoker/70/

@MylesBorins
Copy link
Contributor Author

One last citgm: https://ci.nodejs.org/job/thealphanerd-smoker/73/
this time off of v5.x because some stuff is broken on master
womp... same stuff is broken on v5.x right now.

@MylesBorins
Copy link
Contributor Author

Another run but this time against 4.x as that is more stable

https://ci.nodejs.org/job/thealphanerd-smoker/75/

Looks like binary-csv is a bad egg... swapping for csv-parser

this commit adds the following packages to the lookup
  * vinyl
  * vinyl-fs
  * readable-stream
  * ftp
  * split2
  * throughv
  * duplexer2
  * bl
  * binary-csv
  * spdy
  * dicer
  * spdy-transport
  * sax
  * duplexify
  * pumpify
  * from2
  * flush-write-stream
  * jsonstream
  * csv-parser
@MylesBorins
Copy link
Contributor Author

new citgm run with csv-parser
citgm: https://ci.nodejs.org/job/thealphanerd-smoker/77/

@MylesBorins MylesBorins merged commit faa599e into nodejs:master Feb 15, 2016
@MylesBorins MylesBorins deleted the streams branch February 15, 2016 22:59
@phated
Copy link

phated commented Feb 15, 2016

You rock @thealphanerd!! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants