-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lookup: add packages that test streams #68
Conversation
LGTM
|
through2 if it's not in there is pretty heavily depended on even though it's fairly small split2, throughv, duplexer2 test some interesting parts of streams bl is heavily used and uses streams for some of its functions, is it in the list? binary-split and binary-csv are also interesting use-cases worth poking at |
I use |
|
https://github.com/mafintosh/duplexify are pretty heavily relied on as well. if a module is using readable-stream internally instead of core streams will they still be tested? |
I think we want a mixture of both |
https://github.com/isaacs/sax-js is pretty crucial to a lot of streaming XML parsing |
Its just a collection of what is mostly already listed here, but https://github.com/maxogden/mississippi The missing importaint ones would be: https://www.npmjs.com/package/from2 |
115c194
to
a449e8b
Compare
a run of citgm in CI with these packages |
Looks like failures for both bl and vinyl-fs Going to run individual citgm's for each on to make debugging cleaner bl: https://ci.nodejs.org/job/thealphanerd-smoker/60/ |
Oh, let's not forget jsonstream |
One more round of citgm: https://ci.nodejs.org/job/thealphanerd-smoker/70/ |
One last citgm: https://ci.nodejs.org/job/thealphanerd-smoker/73/ |
Another run but this time against 4.x as that is more stable https://ci.nodejs.org/job/thealphanerd-smoker/75/ Looks like binary-csv is a bad egg... swapping for csv-parser |
this commit adds the following packages to the lookup * vinyl * vinyl-fs * readable-stream * ftp * split2 * throughv * duplexer2 * bl * binary-csv * spdy * dicer * spdy-transport * sax * duplexify * pumpify * from2 * flush-write-stream * jsonstream * csv-parser
new citgm run with csv-parser |
You rock @thealphanerd!! 🍻 |
this commit adds the following packages to the lookup
Please feel free to submit more ideas and I'll add them to the list if they work. If they don't, we'll try and get them to 😄
/cc @jasnell @chrisdickinson @phated @nodejs/streams