lookup: add new modules #296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
gdams
force-pushed
the
mods
branch
2 times, most recently
from
2f1ed9d to
61d64e0
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@gdams have you tested these? I the citgm run on them are clean I'm positive with this landing |
|
@MylesBorins this is clean on IBM jenkins but will need a run in the smoker job to confirm |
|
@gdams is this Pr now updated with appropriate flakyness? If so LGTM |
gdams
force-pushed
the
mods
branch
2 times, most recently
from
2c46f8f to
6d92821
Compare
|
@gdams is there anything blocking this? |
|
@gdams can you please rebase and add maintainers please |
Adding some new modules discussed in nodejs#127
|
@MylesBorins updated PTAL |
|
landed in b88c177 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some new modules discussed in #127