doc: add architecture to release overview #3996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an architecture diagram to the release overview. Keep the existing flow chart as an "In Detail" section.
richardlau
force-pushed
the
release-overview
branch
from
6cf13c2 to
7655d35
Compare
|
The preview doesn't work for me. I see infinite loading spinners. |
UlisesGascon
approved these changes
Jan 14, 2025
|
@targos strange I just checked again and it was ok for me. Which browser are you using? |
|
Firefox |
|
Firefox on Windows seemed to display for me as well so not sure what's going on. |
|
Ok, I reloaded the page a few times and it worked. |
targos
approved these changes
Jan 20, 2025
|
FWIW if relying on GitHub to render the mermaid becomes an issue, we can use https://github.com/mermaid-js/mermaid-cli to render the mermaid definition as SVG. That would introduce a secondary build step to update the diagram, so I'd like to avoid that if possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an architecture diagram to the release overview. Keep the existing flow chart as an "In Detail" section.
Preview: https://github.com/richardlau/build/blob/release-overview/doc/release-overview.md