Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ansible: add gcc-toolset-10-binutils #3596

Merged
merged 2 commits into from
Dec 22, 2023
Merged

ansible: add gcc-toolset-10-binutils #3596

merged 2 commits into from
Dec 22, 2023

Conversation

richardlau
Copy link
Member

Add the gcc-toolset-10 version of binutils to all RHEL 8 based containers.

Refs: #3595 (comment)

Untested.

@richardlau
ansible: add gcc-toolset-10-binutils
52df930 
Add the `gcc-toolset-10` version of `binutils` to all RHEL 8 based
containers.
@richardlau richardlau mentioned this pull request Dec 18, 2023
Open
mhdawson
mhdawson approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

targos
targos approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not gcc-toolset-10-binutils-2.35-11.el8.x86_64.rpm ?

@richardlau
Copy link
Member Author

Why not gcc-toolset-10-binutils-2.35-11.el8.x86_64.rpm ?

No particular reason other than I picked the one that had "el8_5" for consistency. On reflection it shouldn't matter so I've updated to use the later version.

@targos targos self-assigned this Dec 21, 2023
@targos
Copy link
Member

targos commented Dec 21, 2023

I'm deploying this. rhel8 are done.

@targos
Copy link
Member

targos commented Dec 21, 2023 •
edited
Loading

CI for the V8 update: https://ci.nodejs.org/job/node-test-pull-request/56434/ https://ci.nodejs.org/job/node-test-pull-request/56435/

@targos
Copy link
Member

targos commented Dec 21, 2023

All deployed.

@targos
Copy link
Member

targos commented Dec 21, 2023

Passed: https://ci.nodejs.org/job/node-test-commit-arm/50556/nodes=rhel8-arm64/

@targos targos merged commit 94ff7b6 into main Dec 22, 2023
2 checks passed
@targos targos deleted the gcc-toolset-10 branch December 22, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@targos targos targos approved these changes

Assignees

@targos targos

Labels
ansible platform:arm platform:linux-intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@richardlau @targos @UlisesGascon @mhdawson