Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ansible: document .ssh manual setup for release #2117

Merged
merged 2 commits into from
Jan 7, 2020
Merged

ansible: document .ssh manual setup for release #2117

merged 2 commits into from
Jan 7, 2020

Conversation

sam-github
Copy link
Contributor

No description provided.

@sam-github
Copy link
Contributor Author

Discovered while investigating ci-release failure: https://ci-release.nodejs.org/job/iojs+release/4970/nodes=rhel7-s390x-release/console

cf. #2080

08:47:41 ssh node-www "mkdir -p nodejs/custom/v12.14.1-rc.0"
08:47:41 ssh: Could not resolve hostname node-www: Name or service not known
08:47:41 Makefile:1139: recipe for target 'binary-upload' failed
08:47:41 make: *** [binary-upload] Error 255
08:47:41 Build step 'Conditional steps (multiple)' marked build as failure

@sam-github
Copy link
Contributor Author

ci: https://ci-release.nodejs.org/job/iojs+release/4971/

rvagg
rvagg reviewed Jan 1, 2020
View reviewed changes
ansible/MANUAL_STEPS.md Outdated Show resolved Hide resolved
@rvagg
Copy link
Member

rvagg commented Jan 1, 2020

thanks for doing this, long overdue!

@sam-github
Copy link
Contributor Author

take a look at the fixup. @rvagg

rvagg
rvagg approved these changes Jan 1, 2020
View reviewed changes
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tthe iojs-www is no longer required btw, there's no chance of ever publishing an iojs again so this is purely a holdover.

mhdawson
mhdawson approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sam-github sam-github merged commit adcc075 into nodejs:master Jan 7, 2020
@sam-github sam-github deleted the release-setup branch January 7, 2020 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvagg rvagg rvagg approved these changes

@mhdawson mhdawson mhdawson approved these changes

@AshCripps AshCripps AshCripps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sam-github @rvagg @mhdawson @AshCripps